Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751799AbdHBAqU (ORCPT ); Tue, 1 Aug 2017 20:46:20 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:36924 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751368AbdHBAqS (ORCPT ); Tue, 1 Aug 2017 20:46:18 -0400 Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\)) Subject: Re: [PATCH v2 1/4] mm: refactoring TLB gathering API From: Nadav Amit In-Reply-To: <20170801103032.h7tnxryoxx7k7aqg@techsingularity.net> Date: Tue, 1 Aug 2017 17:46:14 -0700 Cc: Andrew Morton , LKML , "open list:MEMORY MANAGEMENT" , kernel-team , Ingo Molnar , Russell King , Tony Luck , Martin Schwidefsky , "David S. Miller" , Heiko Carstens , Yoshinori Sato , Jeff Dike , linux-arch@vger.kernel.org, Mel Gorman Message-Id: <59138710-3EFB-4D59-BD5B-D97CAFEBF098@gmail.com> References: <1501566977-20293-1-git-send-email-minchan@kernel.org> <1501566977-20293-2-git-send-email-minchan@kernel.org> <20170801103032.h7tnxryoxx7k7aqg@techsingularity.net> To: Minchan Kim X-Mailer: Apple Mail (2.3273) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v720kO9b006890 Content-Length: 1503 Lines: 43 Mel Gorman wrote: > On Tue, Aug 01, 2017 at 02:56:14PM +0900, Minchan Kim wrote: >> This patch is ready for solving race problems caused by TLB batch. > > s/is ready/is a preparatory patch/ > >> For that, we will increase/decrease TLB flush pending count of >> mm_struct whenever tlb_[gather|finish]_mmu is called. >> >> Before making it simple, this patch separates architecture specific >> part and rename it to arch_tlb_[gather|finish]_mmu and generic part >> just calls it. >> >> It shouldn't change any behavior. >> >> Cc: Ingo Molnar >> Cc: Russell King >> Cc: Tony Luck >> Cc: Martin Schwidefsky >> Cc: "David S. Miller" >> Cc: Heiko Carstens >> Cc: Yoshinori Sato >> Cc: Jeff Dike >> Cc: linux-arch@vger.kernel.org >> Cc: Nadav Amit >> Cc: Mel Gorman >> Signed-off-by: Minchan Kim > > You could alias arch_generic_tlb_finish_mmu as arch_tlb_gather_mmu > simiilar to how other arch-generic helpers are done to avoid some > #ifdeffery but otherwise Minchan, Andrew wishes me to send one series that combines both series. What about this comment from Mel? It seems you intentionally did not want to alias them... BTW: patch 4 should add “#include " - I’ll add it. Thanks, Nadav