Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751729AbdHBBTy (ORCPT ); Tue, 1 Aug 2017 21:19:54 -0400 Received: from conssluserg-05.nifty.com ([210.131.2.90]:35391 "EHLO conssluserg-05.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751049AbdHBBTw (ORCPT ); Tue, 1 Aug 2017 21:19:52 -0400 DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-05.nifty.com v721JXHR030519 X-Nifty-SrcIP: [209.85.161.181] MIME-Version: 1.0 In-Reply-To: References: <1499140415-31677-1-git-send-email-yamada.masahiro@socionext.com> <1499162760.22624.246.camel@linux.intel.com> <1501509867.29303.303.camel@linux.intel.com> From: Masahiro Yamada Date: Wed, 2 Aug 2017 10:19:32 +0900 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH] gpio: drop unnecessary includes from include/linux/gpio/driver.h To: Andy Shevchenko , Linus Walleij Cc: Andy Shevchenko , "linux-gpio@vger.kernel.org" , Grygorii Strashko , William Breathitt Gray , Ray Jui , =?UTF-8?Q?S=C3=B6ren_Brinkmann?= , David Cohen , Scott Branden , ACPI Devel Maling List , bcm-kernel-feedback-list , Florian Fainelli , Thierry Reding , Jonathan Hunter , Alexander Shiyan , Michal Simek , Kevin Hilman , "linux-tegra@vger.kernel.org" , Joel Stanley , Linux-OMAP , "linux-arm-kernel@lists.infradead.org" , Mika Westerberg , patches@opensource.cirrus.com, Alban Bedel , "linux-kernel@vger.kernel.org" , Santosh Shilimkar , Thor Thayer , Tien Hock Loh Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1836 Lines: 58 Hi. 2017-08-01 20:04 GMT+09:00 Andy Shevchenko : > On Tue, Aug 1, 2017 at 10:53 AM, Linus Walleij wrote: >> On Mon, Jul 31, 2017 at 4:04 PM, Andy Shevchenko >> wrote: >>> On Mon, 2017-07-31 at 15:48 +0200, Linus Walleij wrote: >>>> On Tue, Jul 4, 2017 at 12:06 PM, Andy Shevchenko >>>> wrote: > >>>> > If Linus is okay with the following proposal I would rather go with >>>> > it, >>>> > i.e. logical split the series to >>>> > >>>> > 1. Fix IRQ related headers inclusion >>>> > 2. Fix pinconf-generic.h inclusion >>>> > 3. Fix OF headers inclusion (btw, of_gpio.h is not enough there?) >>>> >>>> That works fine with me, but also one big patch actually, I do not >>>> want to make it too much work to refactor obviously incorrect things. >>>> >>>> As soon as we have rough consensus on this and the build robot >>>> are happy I will apply it to GPIO and also pull it into the pinctrl >>>> subsystem. >>> >>> For me priorities like this: >>> 1) it works after the patch being applied (no regressions); >>> 2) it makes code cleaner at the end; >>> 3) it is presented in logically split parts. >>> >>> So, as long as 1) and 2) are satisfied I can neglect on 3). >> >> We are in violent agreement :D > > What I would like to say is that is up to you after all :-) > For me looks better to split. I will split this into sensible chunks. As I mentioned before, linux/gpio/driver.h is included from several sub-systems, so I need at least two development cycles to finish this task. Maybe, [1] Send patches to subsystems (gpio, pinctrl, etc.) for v4.14 (splitting into sensible chunks, like per-driver) [2] Drop unneeded includes from linux/gpio/driver.h for v4.15 -- Best Regards Masahiro Yamada