From: James Seong-Won Ban <James.Ban.opensource@diasemi.com>
To: Anton Vasilyev <vasilyev@ispras.ru>
CC: Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "ldv-project@linuxtesting.org" <ldv-project@linuxtesting.org>,
        "Eric Hyeung Dong Jeong" <eric.jeong@diasemi.com>
Subject: RE: Buffer overread in pv88090-regulator.ko
Thread-Topic: Buffer overread in pv88090-regulator.ko
Thread-Index: AQHTCuAIHEz+VrGYJE2YEptBq+XaEaJwW+mg
Date: Wed, 2 Aug 2017 02:44:01 +0000
Message-ID: <0ACAE736BB7A70499F1D8D5E6AC1854C0337FB3346@NB-EX-MBX01.diasemi.com>
References: <f9ef2a3b-0e8d-199c-bc44-423ef6e963fc@ispras.ru>
In-Reply-To: <f9ef2a3b-0e8d-199c-bc44-423ef6e963fc@ispras.ru>
Accept-Language: ko-KR, de-DE, en-US
Content-Language: en-US
x-kse-attachmentfiltering-interceptor-info: protection disabled
x-kse-serverinfo: NB-EX-CASHUB02.diasemi.com, 9
x-kse-antivirus-interceptor-info: scan successful
x-kse-antivirus-info: Clean, bases: 02.08.2017 00:04:00
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by nfs id v722iDwf014184
Content-Length: 1460
Lines: 43

Hi Anton,

I have not thought this driver should be loaded for any malicious device.
Anyway we will update it.

Regards,
James

> -----Original Message-----
> From: Anton Vasilyev [mailto:vasilyev@ispras.ru]
> Sent: Wednesday, August 02, 2017 1:06 AM
> To: James Seong-Won Ban
> Cc: Liam Girdwood; Mark Brown; linux-kernel@vger.kernel.org; ldv-
> project@linuxtesting.org
> Subject: Buffer overread in pv88090-regulator.ko
> 
> Hello.
> 
> While searching for memory errors in Linux kernel I've come across
> drivers/regulator/pv88090-regulator.ko module.
> 
> Buffer overread could occur at pv88090_i2c_probe():
> 
> If read from malicious device such values for conf2 and range (e.g. 0x10000000
> and 0x1000 for PV88090_ID_BUCK2) that
>              conf2 = (conf2 >> PV88090_BUCK_VDAC_RANGE_SHIFT) &
>                  PV88090_BUCK_VDAC_RANGE_MASK; and
>              range = (range >>
>                   (PV88080_BUCK_VRANGE_GAIN_SHIFT + i - 1)) &
>                  PV88080_BUCK_VRANGE_GAIN_MASK; become 1 then
>              index = ((range << 1) | conf2); become 3, but index is used for
> dereference pv88090_buck_vol[3].
> 
> Should be index=3 considered as incorrect value and pv88090_i2c_probe() must
> return error, or pv88090_buck_vol[] should be expanded?
> 
> Found by Linux Driver Verification project (linuxtesting.org).
> 
> --
> Anton Vasilyev
> Linux Verification Center, ISPRAS
> web: http://linuxtesting.org
> e-mail: vasilyev@ispras.ru