Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbdHBDGy (ORCPT ); Tue, 1 Aug 2017 23:06:54 -0400 Received: from smtp.csie.ntu.edu.tw ([140.112.30.61]:51114 "EHLO smtp.csie.ntu.edu.tw" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751533AbdHBDGw (ORCPT ); Tue, 1 Aug 2017 23:06:52 -0400 MIME-Version: 1.0 In-Reply-To: <20170729141753.20174-7-codekipper@gmail.com> References: <20170729141753.20174-1-codekipper@gmail.com> <20170729141753.20174-7-codekipper@gmail.com> From: Chen-Yu Tsai Date: Wed, 2 Aug 2017 11:06:27 +0800 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [linux-sunxi] [PATCH v3 06/12] ASoC: sun4i-i2s: Add changes for wss and sr To: Code Kipper Cc: Maxime Ripard , linux-arm-kernel , linux-sunxi , Liam Girdwood , Mark Brown , linux-kernel , Linux-ALSA , "Andrea Venturi (pers)" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 30 On Sat, Jul 29, 2017 at 10:17 PM, wrote: > From: Marcus Cooper > > On newer SoCs the location of the slot width select and sample > resolution are different and also there is a bigger range of > support. > > For the current supported rates then an offset is required. > > Signed-off-by: Marcus Cooper > --- > sound/soc/sunxi/sun4i-i2s.c | 31 ++++++++++++++++++++++++++++--- > 1 file changed, 28 insertions(+), 3 deletions(-) > > diff --git a/sound/soc/sunxi/sun4i-i2s.c b/sound/soc/sunxi/sun4i-i2s.c > index 120f797a38e8..171df99a267e 100644 > --- a/sound/soc/sunxi/sun4i-i2s.c > +++ b/sound/soc/sunxi/sun4i-i2s.c > @@ -98,6 +98,9 @@ > * @sun4i_i2s_regmap: regmap config to use. > * @mclk_offset: Value by which mclkdiv needs to be adjusted. > * @bclk_offset: Value by which bclkdiv needs to be adjusted. > + * @fmt_offset: Value by which wss and sr needs to be adjusted. > + * @field_fmt_set_wss: regmap field to set word select size. > + * @field_fmt_set_sr: regmap field to set sample resolution. One more thing. Is "_set_" necessary? "field_fmt_wss" seems fine and makes plenty of sense to me. ChenYu