Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752024AbdHBDJ7 (ORCPT ); Tue, 1 Aug 2017 23:09:59 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:42934 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751746AbdHBDJ6 (ORCPT ); Tue, 1 Aug 2017 23:09:58 -0400 Date: Tue, 01 Aug 2017 20:09:56 -0700 (PDT) Message-Id: <20170801.200956.2244963133644668921.davem@davemloft.net> To: vivien.didelot@savoirfairelinux.com Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, f.fainelli@gmail.com, andrew@lunn.ch, john@phrozen.org Subject: Re: [PATCH net-next v2 00/11] net: dsa: rework EEE support From: David Miller In-Reply-To: <20170801203241.22294-1-vivien.didelot@savoirfairelinux.com> References: <20170801203241.22294-1-vivien.didelot@savoirfairelinux.com> X-Mailer: Mew version 6.7 on Emacs 25.2 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Tue, 01 Aug 2017 20:09:57 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 938 Lines: 20 From: Vivien Didelot Date: Tue, 1 Aug 2017 16:32:30 -0400 > EEE implies configuring the port's PHY and MAC of both ends of the wire. > > The current EEE support in DSA mixes PHY and MAC configuration, which is > bad because PHYs must be configured through a proper PHY driver. The DSA > switch operations for EEE are only meant for configuring the port's MAC, > which are integrated in the Ethernet switch device. > > This patchset fixes the EEE support in qca8k driver, makes the DSA layer > call phy_init_eee for all drivers, and remove the EEE support from the > mv88e6xxx driver since the Marvell PHY driver should be enough for it. > > Changes in v2: > - make PHY device and DSA EEE ops mandatory for slave EEE operations. > - simply return 0 in drivers which don't need to do anything to > configure the port' MAC. Subsequent PHY calls will be enough. Series applied, thanks Vivien.