Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751809AbdHBFv6 (ORCPT ); Wed, 2 Aug 2017 01:51:58 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46372 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdHBFv5 (ORCPT ); Wed, 2 Aug 2017 01:51:57 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org E1E35602B5 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v2 05/25] mtd: nand: qcom: remove redundant chip select compatible string To: Abhishek Sahu , dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, sricharan@codeaurora.org References: <1500464893-11352-1-git-send-email-absahu@codeaurora.org> <1500464893-11352-6-git-send-email-absahu@codeaurora.org> From: Archit Taneja Message-ID: <248e1459-5cec-32c6-1de8-8f5478a8f5da@codeaurora.org> Date: Wed, 2 Aug 2017 11:21:50 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1500464893-11352-6-git-send-email-absahu@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1994 Lines: 65 On 07/19/2017 05:17 PM, Abhishek Sahu wrote: > Currently the compatible “qcom,nandcs” is being used for each > connected NAND device to support for multiple NAND devices in the > same bus. The same thing can be achieved by looking reg property > for each sub nodes which contains the chip select number so this > patch removes the use of “qcom,nandcs” for specifying NAND device > sub nodes. > > Since there is no user for this driver currently in so > changing compatible string is safe. Reviewed-by: Archit Taneja > > Signed-off-by: Abhishek Sahu > --- > drivers/mtd/nand/qcom_nandc.c | 26 ++++++++++++-------------- > 1 file changed, 12 insertions(+), 14 deletions(-) > > diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c > index 8fa2f0c..110a26a 100644 > --- a/drivers/mtd/nand/qcom_nandc.c > +++ b/drivers/mtd/nand/qcom_nandc.c > @@ -2129,22 +2129,20 @@ static int qcom_nandc_probe(struct platform_device *pdev) > goto err_setup; > > for_each_available_child_of_node(dn, child) { > - if (of_device_is_compatible(child, "qcom,nandcs")) { > - host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL); > - if (!host) { > - of_node_put(child); > - ret = -ENOMEM; > - goto err_cs_init; > - } > - > - ret = qcom_nand_host_init(nandc, host, child); > - if (ret) { > - devm_kfree(dev, host); > - continue; > - } > + host = devm_kzalloc(dev, sizeof(*host), GFP_KERNEL); > + if (!host) { > + of_node_put(child); > + ret = -ENOMEM; > + goto err_cs_init; > + } > > - list_add_tail(&host->node, &nandc->host_list); > + ret = qcom_nand_host_init(nandc, host, child); > + if (ret) { > + devm_kfree(dev, host); > + continue; > } > + > + list_add_tail(&host->node, &nandc->host_list); > } > > if (list_empty(&nandc->host_list)) { > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project