Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751788AbdHBGGV (ORCPT ); Wed, 2 Aug 2017 02:06:21 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:33636 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751112AbdHBGGT (ORCPT ); Wed, 2 Aug 2017 02:06:19 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org AE076607C6 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v2 09/25] mtd: nand: qcom: remove memset for clearing read register buffer To: Abhishek Sahu , dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com Cc: devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, andy.gross@linaro.org, sricharan@codeaurora.org References: <1500464893-11352-1-git-send-email-absahu@codeaurora.org> <1500464893-11352-10-git-send-email-absahu@codeaurora.org> From: Archit Taneja Message-ID: <3804c0db-940d-24d6-dae0-7965bfb3f259@codeaurora.org> Date: Wed, 2 Aug 2017 11:36:12 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1500464893-11352-10-git-send-email-absahu@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1101 Lines: 35 On 07/19/2017 05:17 PM, Abhishek Sahu wrote: > The memset in clear_read_regs is overhead. All the register data > will be filled by DMA during NAND operation so making these > register variables zero is not required. Yeah, that's a good point. Reviewed-by: Archit Taneja > > Signed-off-by: Abhishek Sahu > --- > drivers/mtd/nand/qcom_nandc.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c > index 5b71478..7ecd0f8 100644 > --- a/drivers/mtd/nand/qcom_nandc.c > +++ b/drivers/mtd/nand/qcom_nandc.c > @@ -826,8 +826,6 @@ static void free_descs(struct qcom_nand_controller *nandc) > static void clear_read_regs(struct qcom_nand_controller *nandc) > { > nandc->reg_read_pos = 0; > - memset(nandc->reg_read_buf, 0, > - MAX_REG_RD * sizeof(*nandc->reg_read_buf)); > } > > static void pre_command(struct qcom_nand_host *host, int command) > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project