Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752043AbdHBIKl (ORCPT ); Wed, 2 Aug 2017 04:10:41 -0400 Received: from mailout01.webmailer.hosteurope.de ([80.237.138.57]:59414 "EHLO mailout01.webmailer.hosteurope.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751142AbdHBIKk (ORCPT ); Wed, 2 Aug 2017 04:10:40 -0400 X-Squirrel-UserHash: EhVcX1pHQwdXWkQFBhENSgEKLlwACw== X-Squirrel-FromHash: UwFaC1lCF1E= Message-ID: <061c039eb1e6896887b9cad71216c4c7-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAlZWXcFVl0=-webmailer1@server03.webmailer.webmailer.hosteurope.de> In-Reply-To: <1501615919-31875-3-git-send-email-rishabhhardas@gmail.com> References: <1501615919-31875-1-git-send-email-rishabhhardas@gmail.com> <1501615919-31875-3-git-send-email-rishabhhardas@gmail.com> Date: Wed, 2 Aug 2017 10:10:38 +0200 Subject: Re: [PATCH 3/5] staging/pi433/rf69.h:Removed Coding style issues from pi433_if.h and other dependencies arising from it. From: "Wolf Entwicklungen" To: "Rishabh Hardas" Cc: gregkh@linuxfoundation.org, linux@Wolf-Entwicklungen.de, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, "Rishabh Hardas" Reply-To: Marcus.Wolf@Wolf-Entwicklungen.de User-Agent: Host Europe Webmailer/1.0 MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7BIT X-Priority: 3 (Normal) Importance: Normal X-KLMS-Rule-ID: 1 X-KLMS-Message-Action: clean X-KLMS-AntiSpam-Status: not scanned, license restriction X-KLMS-AntiPhishing: not scanned, license restriction X-KLMS-AntiVirus: Kaspersky Security 8.0 for Linux Mail Server, version 8.0.1.721, bases: 2017/08/02 01:57:00 #10257287; khse: 2015-01-01 01:01:01 X-KLMS-AntiVirus-Status: Clean, skipped X-HE-Access: Yes X-bounce-key: webpack.hosteurope.de;marcus.wolf@wolf-entwicklungen.de;1501661438;3ef46709; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 5281 Lines: 77 Reviewed-by: Marcus Wolf Am Di, 1.08.2017, 21:31 schrieb Rishabh Hardas: > Signed-off-by: Rishabh Hardas > --- > drivers/staging/pi433/rf69.h | 26 +++++++++++++------------- > 1 file changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/pi433/rf69.h b/drivers/staging/pi433/rf69.h > index b81e076..e98e24e 100644 > --- a/drivers/staging/pi433/rf69.h > +++ b/drivers/staging/pi433/rf69.h > @@ -29,18 +29,18 @@ int rf69_set_mode(struct spi_device *spi, enum mode mode); > int rf69_set_data_mode(struct spi_device *spi, enum dataMode dataMode); > int rf69_set_modulation(struct spi_device *spi, enum modulation modulation); > enum modulation rf69_get_modulation(struct spi_device *spi); > -int rf69_set_modulation_shaping(struct spi_device *spi, enum modShaping modShaping); > +int rf69_set_modulation_shaping(struct spi_device *spi, enum mod_shaping modShaping); > int rf69_set_bit_rate(struct spi_device *spi, u16 bitRate); > int rf69_set_deviation(struct spi_device *spi, u32 deviation); > int rf69_set_frequency(struct spi_device *spi, u32 frequency); > -int rf69_set_amplifier_0(struct spi_device *spi, enum optionOnOff optionOnOff); > -int rf69_set_amplifier_1(struct spi_device *spi, enum optionOnOff optionOnOff); > -int rf69_set_amplifier_2(struct spi_device *spi, enum optionOnOff optionOnOff); > +int rf69_set_amplifier_0(struct spi_device *spi, enum option_on_off optionOnOff); > +int rf69_set_amplifier_1(struct spi_device *spi, enum option_on_off optionOnOff); > +int rf69_set_amplifier_2(struct spi_device *spi, enum option_on_off optionOnOff); > int rf69_set_output_power_level(struct spi_device *spi, u8 powerLevel); > -int rf69_set_pa_ramp(struct spi_device *spi, enum paRamp paRamp); > -int rf69_set_antenna_impedance(struct spi_device *spi, enum antennaImpedance antennaImpedance); > -int rf69_set_lna_gain(struct spi_device *spi, enum lnaGain lnaGain); > -enum lnaGain rf69_get_lna_gain(struct spi_device *spi); > +int rf69_set_pa_ramp(struct spi_device *spi, enum pa_ramp paRamp); > +int rf69_set_antenna_impedance(struct spi_device *spi, enum antenna_impedance antennaImpedance); > +int rf69_set_lna_gain(struct spi_device *spi, enum lnagain lnaGain); > +enum lnagain rf69_get_lna_gain(struct spi_device *spi); > int rf69_set_dc_cut_off_frequency_intern(struct spi_device *spi, u8 reg, enum dccPercent dccPercent); > int rf69_set_dc_cut_off_frequency(struct spi_device *spi, enum dccPercent dccPercent); > int rf69_set_dc_cut_off_frequency_during_afc(struct spi_device *spi, enum dccPercent dccPercent); > @@ -48,7 +48,7 @@ int rf69_set_bandwidth(struct spi_device *spi, enum mantisse mantisse, u8 expone > int rf69_set_bandwidth_during_afc(struct spi_device *spi, enum mantisse mantisse, u8 exponent); > int rf69_set_ook_threshold_type(struct spi_device *spi, enum thresholdType thresholdType); > int rf69_set_ook_threshold_step(struct spi_device *spi, enum thresholdStep thresholdStep); > -int rf69_set_ook_threshold_dec(struct spi_device *spi, enum thresholdDecrement thresholdDecrement); > +int rf69_set_ook_threshold_dec(struct spi_device *spi, enum threshold_decrement thresholdDecrement); > int rf69_set_dio_mapping(struct spi_device *spi, u8 DIONumber, u8 value); > bool rf69_get_flag(struct spi_device *spi, enum flag flag); > int rf69_reset_flag(struct spi_device *spi, enum flag flag); > @@ -56,18 +56,18 @@ int rf69_set_rssi_threshold(struct spi_device *spi, u8 threshold); > int rf69_set_rx_start_timeout(struct spi_device *spi, u8 timeout); > int rf69_set_rssi_timeout(struct spi_device *spi, u8 timeout); > int rf69_set_preamble_length(struct spi_device *spi, u16 preambleLength); > -int rf69_set_sync_enable(struct spi_device *spi, enum optionOnOff optionOnOff); > +int rf69_set_sync_enable(struct spi_device *spi, enum option_on_off optionOnOff); > int rf69_set_fifo_fill_condition(struct spi_device *spi, enum fifoFillCondition fifoFillCondition); > int rf69_set_sync_size(struct spi_device *spi, u8 sync_size); > int rf69_set_sync_tolerance(struct spi_device *spi, u8 syncTolerance); > int rf69_set_sync_values(struct spi_device *spi, u8 syncValues[8]); > int rf69_set_packet_format(struct spi_device * spi, enum packetFormat packetFormat); > -int rf69_set_crc_enable(struct spi_device *spi, enum optionOnOff optionOnOff); > -int rf69_set_adressFiltering(struct spi_device *spi, enum addressFiltering addressFiltering); > +int rf69_set_crc_enable(struct spi_device *spi, enum option_on_off optionOnOff); > +int rf69_set_adressFiltering(struct spi_device *spi, enum address_filtering addressFiltering); > int rf69_set_payload_length(struct spi_device *spi, u8 payloadLength); > u8 rf69_get_payload_length(struct spi_device *spi); > int rf69_set_node_address(struct spi_device *spi, u8 nodeAddress); > int rf69_set_broadcast_address(struct spi_device *spi, u8 broadcastAddress); > -int rf69_set_tx_start_condition(struct spi_device *spi, enum txStartCondition txStartCondition); > +int rf69_set_tx_start_condition(struct spi_device *spi, enum tx_start_condition txStartCondition); > int rf69_set_fifo_threshold(struct spi_device *spi, u8 threshold); > int rf69_set_dagc(struct spi_device *spi, enum dagc dagc); > > -- > 2.7.4 > > >