Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752055AbdHBITj (ORCPT ); Wed, 2 Aug 2017 04:19:39 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:47209 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751121AbdHBITi (ORCPT ); Wed, 2 Aug 2017 04:19:38 -0400 Date: Wed, 2 Aug 2017 11:19:24 +0300 From: Dan Carpenter To: Rishabh Hardas Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux@Wolf-Entwicklungen.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from pi433_if.h and other dependencies arising from it. Message-ID: <20170802081923.j5whbxqaztj3fit5@mwanda> References: <1501615919-31875-1-git-send-email-rishabhhardas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501615919-31875-1-git-send-email-rishabhhardas@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 682 Lines: 22 The subject is too long. On Wed, Aug 02, 2017 at 01:01:55AM +0530, Rishabh Hardas wrote: > This is a 5 patch series which solves coding style issues > as marked by checkpatch.pl in the file pi433_if.h and > contains changes that have to be made in other files as a > consequence of the changes made in pi433_if.h This looks like the description of 5 patches, but that should be in the [PATCH 0/5] summary. What we want here is the description of this patch. This patch does too many things, deleting stuff, breaking up long lines, changing comments and renaming enums. It should be 4 patches: [patch 1] delete stuff [patch 2] break long lines ... etc. regards, dan carpenter