Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752253AbdHBIZz (ORCPT <rfc822;w@1wt.eu>);
        Wed, 2 Aug 2017 04:25:55 -0400
Received: from mail-it0-f52.google.com ([209.85.214.52]:37186 "EHLO
        mail-it0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751891AbdHBIZx (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 2 Aug 2017 04:25:53 -0400
MIME-Version: 1.0
In-Reply-To: <20170711180339.GA17806@embeddedgus>
References: <20170711180339.GA17806@embeddedgus>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Wed, 2 Aug 2017 10:25:50 +0200
Message-ID: <CACRpkdZCJzqKnHDFy4ga6n-NMMs21m80_i1=O_2VPua4yx3rfg@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: bcm2835: constify gpio_chip structure
To: "Gustavo A. R. Silva" <garsilva@embeddedor.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>, Ray Jui <rjui@broadcom.com>,
        Scott Branden <sbranden@broadcom.com>, Eric Anholt <eric@anholt.net>,
        Stefan Wahren <stefan.wahren@i2se.com>,
        bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        linux-rpi-kernel <linux-rpi-kernel@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1259
Lines: 53

On Tue, Jul 11, 2017 at 8:03 PM, Gustavo A. R. Silva
<garsilva@embeddedor.com> wrote:

> This structure is only used to copy into other structure, so declare
> it as const.
>
> This issue was detected using Coccinelle and the following semantic patch:
>
> @r disable optional_qualifier@
> identifier i;
> position p;
> @@
> static struct gpio_chip i@p = { ... };
>
> @ok@
> identifier r.i;
> expression e;
> position p;
> @@
> e = i@p;
>
> @bad@
> position p != {r.p,ok.p};
> identifier r.i;
> struct gpio_chip e;
> @@
> e@i@p
>
> @depends on !bad disable optional_qualifier@
> identifier r.i;
> @@
> static
> +const
>  struct gpio_chip i = { ... };
>
> In the following log you can see a significant difference in the code size
> and data segment, hence in the dec segment. This log is the output
> of the size command, before and after the code change:
>
> before:
>    text    data     bss     dec     hex filename
>   18958    9000     128   28086    6db6 drivers/pinctrl/bcm/pinctrl-bcm2835.o
>
> after:
>    text    data     bss     dec     hex filename
>   18764    8912     128   27804    6c9c drivers/pinctrl/bcm/pinctrl-bcm2835.o
>
> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com>

Patch applied with Eric's ACK.

Yours,
Linus Walleij