Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752353AbdHBI0O (ORCPT ); Wed, 2 Aug 2017 04:26:14 -0400 Received: from mail-qt0-f173.google.com ([209.85.216.173]:38143 "EHLO mail-qt0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752232AbdHBI0M (ORCPT ); Wed, 2 Aug 2017 04:26:12 -0400 MIME-Version: 1.0 X-Originating-IP: [90.63.244.31] In-Reply-To: <2153314.vmO4TSUiTO@ws-stein> References: <20170802075126.17637-1-brgl@bgdev.pl> <20170802075126.17637-5-brgl@bgdev.pl> <2153314.vmO4TSUiTO@ws-stein> From: Bartosz Golaszewski Date: Wed, 2 Aug 2017 10:26:11 +0200 Message-ID: Subject: Re: [PATCH 4/6] gpio: mxc: use devres for irq generic chip To: Alexander Stein Cc: Linus Walleij , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 646 Lines: 22 2017-08-02 10:09 GMT+02:00 Alexander Stein : > Hi, > > On Wednesday 02 August 2017 09:51:24, Bartosz Golaszewski wrote: >> Use resource managed variants of irq_alloc_generic_chip() and >> irq_setup_generic_chip(). > > Is this really useful for drivers which can only be built-in? This is probably > valid for the other drives as well. > > Best regards, > Alexander > gpio-pch and gpio-ml-ioh are loadable and they leak the resources allocated with these routines. Other drivers affected by this series already use other devm_*() functions and these changes just make them more consistent. Thanks, Bartosz