Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752454AbdHBI0i (ORCPT ); Wed, 2 Aug 2017 04:26:38 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:50471 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752425AbdHBI0g (ORCPT ); Wed, 2 Aug 2017 04:26:36 -0400 Date: Wed, 2 Aug 2017 11:26:23 +0300 From: Dan Carpenter To: Rishabh Hardas Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux@Wolf-Entwicklungen.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/5] staging/pi433/pi433_if.c:Removed Coding style issues from pi433_if.h and other dependencies arising from it. Message-ID: <20170802082623.kqrvhup3bdqrke7t@mwanda> References: <1501615919-31875-1-git-send-email-rishabhhardas@gmail.com> <1501615919-31875-2-git-send-email-rishabhhardas@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1501615919-31875-2-git-send-email-rishabhhardas@gmail.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 677 Lines: 19 The subject is too vague. The patch prefix isn't right. Do `git log --oneline drivers/staging/pi433/` to see what other people are doing: 99859541a92d staging: pi433: use div_u64 for 64-bit division 056eeda2f9e6 staging: pi433: Style fix - align block comments 775f6ab013d3 staging: pi433: Make functions rf69_set_bandwidth_intern static c7d42f37087d Staging: pi433: check error after kthread_run() 7de77a3917e3 Staging: pi433: declare functions static 0119a48b69fe staging: pi433: depends on SPI So the subject should be something like: [PATCH] staging: pi433: rename camel case variables Also there was no patch description and that's required. regards, dan carpenter