Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752470AbdHBI1V (ORCPT ); Wed, 2 Aug 2017 04:27:21 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:35721 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752174AbdHBI1S (ORCPT ); Wed, 2 Aug 2017 04:27:18 -0400 MIME-Version: 1.0 In-Reply-To: <20170711211836.GA31321@embeddedgus> References: <20170711211836.GA31321@embeddedgus> From: Linus Walleij Date: Wed, 2 Aug 2017 10:27:17 +0200 Message-ID: Subject: Re: [PATCH] pinctrl: qcom: ssbi: mpp: constify gpio_chip structure To: "Gustavo A. R. Silva" Cc: Bjorn Andersson , "linux-arm-msm@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v728RQDZ003808 Content-Length: 1267 Lines: 53 On Tue, Jul 11, 2017 at 11:18 PM, Gustavo A. R. Silva wrote: > This structure is only used to copy into another structure, so declare > it as const. > > This issue was detected using Coccinelle and the following semantic patch: > > @r disable optional_qualifier@ > identifier i; > position p; > @@ > static struct gpio_chip i@p = { ... }; > > @ok@ > identifier r.i; > expression e; > position p; > @@ > e = i@p; > > @bad@ > position p != {r.p,ok.p}; > identifier r.i; > struct gpio_chip e; > @@ > e@i@p > > @depends on !bad disable optional_qualifier@ > identifier r.i; > @@ > static > +const > struct gpio_chip i = { ... }; > > In the following log you can see a significant difference in the code size > and data segment, hence in the dec segment. This log is the output > of the size command, before and after the code change: > > before: > text data bss dec hex filename > 15136 5112 0 20248 4f18 drivers/pinctrl/qcom/pinctrl-ssbi-mpp.o > > after: > bss dec hex filename > 14849 5024 0 19873 4da1 drivers/pinctrl/qcom/pinctrl-ssbi-mpp.o > > Signed-off-by: Gustavo A. R. Silva Patch applied with Björn's review tag. Yours, Linus Walleij