Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752495AbdHBIeW (ORCPT ); Wed, 2 Aug 2017 04:34:22 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:19979 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752423AbdHBIeT (ORCPT ); Wed, 2 Aug 2017 04:34:19 -0400 Date: Wed, 2 Aug 2017 11:34:07 +0300 From: Dan Carpenter To: Wolf Entwicklungen Cc: Rishabh Hardas , devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux@wolf-entwicklungen.de, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from pi433_if.h and other dependencies arising from it. Message-ID: <20170802083406.6d6mtli7pm2w7zrr@mwanda> References: <1501615919-31875-1-git-send-email-rishabhhardas@gmail.com> <88d4ff61d322e563ffd52f7375227f8d-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAlZWXcDXVE=-webmailer1@server03.webmailer.webmailer.hosteurope.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <88d4ff61d322e563ffd52f7375227f8d-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAlZWXcDXVE=-webmailer1@server03.webmailer.webmailer.hosteurope.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1114 Lines: 32 On Wed, Aug 02, 2017 at 10:08:04AM +0200, Wolf Entwicklungen wrote: > Reviewed-by: Marcus Wolf > > Just reviewed, not tested. > As far as I can see, there is no technical issue with this patch. You need to be a bit more strict in your reviews... There were a few obvious problems in this patchset. These are show stoppers: 1) Breaks git bisect 2) Doing multiple things in the same patch 3) No changelog > > I prefer the names of the enumerations in camel case, because then they are a bit shorter. > If camel case is unwanted, for sure we need that change. Camel case are unwanted. > > Please mind the allignment. For enhanced readability of structs, I always try to start the type > in the same column, the variable name in the same column and - if nneded - the comments in the > same column - so you see all members of the struct optically in a kind of table. Rishabh is going to have to redo the patchset anyway so don't feel bad about asking for changes. Put these review comments next to the change you are complaining about. No top posting. regards, dan carpenter