Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752567AbdHBIhA (ORCPT ); Wed, 2 Aug 2017 04:37:00 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:36844 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752344AbdHBIg5 (ORCPT ); Wed, 2 Aug 2017 04:36:57 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 8878A6077A Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=architt@codeaurora.org Subject: Re: [PATCH v2 13/25] mtd: nand: qcom: add QPIC NAND compatible string To: Abhishek Sahu , dwmw2@infradead.org, computersforpeace@gmail.com, boris.brezillon@free-electrons.com, marek.vasut@gmail.com, richard@nod.at, cyrille.pitchen@wedev4u.fr, robh+dt@kernel.org, mark.rutland@arm.com Cc: linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, andy.gross@linaro.org, sricharan@codeaurora.org References: <1500464893-11352-1-git-send-email-absahu@codeaurora.org> <1500464893-11352-14-git-send-email-absahu@codeaurora.org> From: Archit Taneja Message-ID: <973705c0-7915-3239-c150-92dc938e52e6@codeaurora.org> Date: Wed, 2 Aug 2017 14:06:18 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1500464893-11352-14-git-send-email-absahu@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2163 Lines: 66 On 07/19/2017 05:18 PM, Abhishek Sahu wrote: > The current driver only support EBI2 NAND which uses ADM DMA. The s/support/supports > latest QCOM controller supports QPIC NAND which uses BAM DMA. NAND > registers and programming sequence are same for EBI2 and QPIC > NAND so the same driver can support QPIC NAND also by adding the > BAM DMA support. This patch adds the QPIC NAND support in current > NAND driver with compatible string "qcom,qpic-nandc-v1.4.0" and > maps it with different configuration parameter in driver data. > Reviewed-by: Archit Taneja > Signed-off-by: Abhishek Sahu > --- > drivers/mtd/nand/qcom_nandc.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/drivers/mtd/nand/qcom_nandc.c b/drivers/mtd/nand/qcom_nandc.c > index 3b0ae91..6d24630 100644 > --- a/drivers/mtd/nand/qcom_nandc.c > +++ b/drivers/mtd/nand/qcom_nandc.c > @@ -323,9 +323,11 @@ struct qcom_nand_host { > * This data type corresponds to the nand controller properties which varies > * among different NAND controller IP's. > * @ecc_modes - ecc mode for NAND > + * @is_bam - whether NAND controller is using bam > */ > struct qcom_props { > u32 ecc_modes; > + bool is_bam; > }; > > static inline struct qcom_nand_host *to_qcom_nand_host(struct nand_chip *chip) > @@ -2245,6 +2247,12 @@ static int qcom_nandc_remove(struct platform_device *pdev) > > static const struct qcom_props ebi2_nandc_data = { > .ecc_modes = (ECC_RS_4BIT | ECC_BCH_8BIT), > + .is_bam = false, > +}; > + > +static const struct qcom_props qpic_nandc_v1_4_0_data = { > + .ecc_modes = (ECC_BCH_4BIT | ECC_BCH_8BIT), > + .is_bam = true, > }; > > /* > @@ -2255,6 +2263,9 @@ static int qcom_nandc_remove(struct platform_device *pdev) > { .compatible = "qcom,ebi2-nandc", > .data = &ebi2_nandc_data, > }, > + { .compatible = "qcom,qpic-nandc-v1.4.0", > + .data = &qpic_nandc_v1_4_0_data, > + }, > {} > }; > MODULE_DEVICE_TABLE(of, qcom_nandc_of_match); > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project