Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752841AbdHBJdW (ORCPT ); Wed, 2 Aug 2017 05:33:22 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21369 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752577AbdHBJdU (ORCPT ); Wed, 2 Aug 2017 05:33:20 -0400 Date: Wed, 2 Aug 2017 12:33:07 +0300 From: Dan Carpenter To: Wolf Entwicklungen Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Rishabh Hardas , gregkh@linuxfoundation.org Subject: Re: [PATCH 1/5] staging/pi433:Removed Coding style issues from pi433_if.h and other dependencies arising from it. Message-ID: <20170802093307.ngy6243hnv4nuynm@mwanda> References: <1501615919-31875-1-git-send-email-rishabhhardas@gmail.com> <88d4ff61d322e563ffd52f7375227f8d-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAlZWXcDXVE=-webmailer1@server03.webmailer.webmailer.hosteurope.de> <20170802083406.6d6mtli7pm2w7zrr@mwanda> <765971804.35469.1501663956377@ox.hosteurope.de> <20170802085947.i5duktlaov7gayex@mwanda> <29d720045e6b843c9bf6e39d5c5e49eb-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAlZWXMCVFM=-webmailer1@server03.webmailer.webmailer.hosteurope.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29d720045e6b843c9bf6e39d5c5e49eb-EhVcX1pHQwdXWkQFBhENSgEKLlwACzJXX19HAVhEWENbS1kLMF52CEtUX1pBSEwcXlJRL1lQWAlZWXMCVFM=-webmailer1@server03.webmailer.webmailer.hosteurope.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0022.oracle.com [156.151.31.74] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1000 Lines: 26 On Wed, Aug 02, 2017 at 11:15:16AM +0200, Wolf Entwicklungen wrote: > Hi Dan, > > I offered Greg to have an eye on the patches, that were submitted. He asked > me to reply to those patches, I had a look for, with the Reviewed-by tag. > > Now I am a bit unsure, what I should do. > > Since I am interested in, I for sure will read every patch. It's just a little > thing, to reply with reviewed-tag - if you / Greg like(s). I can do so on every > reviewed patch, only on patches without need/wish of improvement or never. > > Compiling every patch is a bit inconvenient. > > Please let me know, what you and Greg would like. That's fine, you don't need to build test them if you don't want to. Greg is going to do it. But in this case, it was pretty obvious that it was going to break git bisect right? That's not allowed. You're not expected to know all the rules when you start so that's fine. I'm just trying to give you some ideas what to look for in the future. regards, dan carpenter