Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752866AbdHBKBd (ORCPT ); Wed, 2 Aug 2017 06:01:33 -0400 Received: from mail-wm0-f66.google.com ([74.125.82.66]:35644 "EHLO mail-wm0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752233AbdHBKBb (ORCPT ); Wed, 2 Aug 2017 06:01:31 -0400 Date: Wed, 2 Aug 2017 12:01:24 +0200 From: Daniel Vetter To: Arnd Bergmann Cc: Bartlomiej Zolnierkiewicz , Daniel Vetter , Dan Carpenter , Sean Paul , Arvind Yadav , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fbdev: matrox: hide unused 'hotplug' variable Message-ID: <20170802100124.bcr3ux6bt4hnlu6r@phenom.ffwll.local> Mail-Followup-To: Arnd Bergmann , Bartlomiej Zolnierkiewicz , Dan Carpenter , Sean Paul , Arvind Yadav , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170802093722.3666961-1-arnd@arndb.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170802093722.3666961-1-arnd@arndb.de> X-Operating-System: Linux phenom 4.11.0-2-amd64 User-Agent: NeoMutt/20170609 (1.8.3) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1282 Lines: 41 On Wed, Aug 02, 2017 at 11:36:47AM +0200, Arnd Bergmann wrote: > The variable has become unused in modular configurations > which triggers a harmless warning: > > drivers/video/fbdev/matrox/matroxfb_base.c:1583:12: error: 'hotplug' defined but not used [-Werror=unused-variable] > > This moves it into an #ifdef section of the file, matching > all its references. > > Fixes: 376b3ff54c9a ("fbdev: Nuke FBINFO_MODULE") > Signed-off-by: Arnd Bergmann Reviewed-by: Daniel Vetter > --- > drivers/video/fbdev/matrox/matroxfb_base.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/video/fbdev/matrox/matroxfb_base.c b/drivers/video/fbdev/matrox/matroxfb_base.c > index fd1589fcdf15..00ea4e4ab95a 100644 > --- a/drivers/video/fbdev/matrox/matroxfb_base.c > +++ b/drivers/video/fbdev/matrox/matroxfb_base.c > @@ -1578,9 +1578,9 @@ static struct fb_videomode defaultmode = { > NULL, 60, 640, 480, 39721, 40, 24, 32, 11, 96, 2, > 0, FB_VMODE_NONINTERLACED > }; > -#endif /* !MODULE */ > > static int hotplug = 0; > +#endif /* !MODULE */ > > static void setDefaultOutputs(struct matrox_fb_info *minfo) > { > -- > 2.9.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch