Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752610AbdHBKjp (ORCPT ); Wed, 2 Aug 2017 06:39:45 -0400 Received: from mail-wr0-f196.google.com ([209.85.128.196]:32910 "EHLO mail-wr0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752100AbdHBKjo (ORCPT ); Wed, 2 Aug 2017 06:39:44 -0400 Subject: Re: [PATCH] soc: mtk-pmic-wrap: make of_device_ids const. To: "chen.zhong" , Arvind Yadav Cc: linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <1498651806.6668.2.camel@mhfsdcap03> From: Matthias Brugger Message-ID: <50025832-8a59-0f05-7be1-91a2d2c309e1@gmail.com> Date: Wed, 2 Aug 2017 12:39:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1498651806.6668.2.camel@mhfsdcap03> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1871 Lines: 53 On 06/28/2017 02:10 PM, chen.zhong wrote: > Hi, > On Wed, 2017-06-28 at 10:28 +0530, Arvind Yadav wrote: >> of_device_ids are not supposed to change at runtime. All functions >> working with of_device_ids provided by work with const >> of_device_ids. So mark the non-const structs as const. >> >> Signed-off-by: Arvind Yadav >> --- >> drivers/soc/mediatek/mtk-pmic-wrap.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/soc/mediatek/mtk-pmic-wrap.c b/drivers/soc/mediatek/mtk-pmic-wrap.c >> index a5f1093..1205a671 100644 >> --- a/drivers/soc/mediatek/mtk-pmic-wrap.c >> +++ b/drivers/soc/mediatek/mtk-pmic-wrap.c >> @@ -1067,7 +1067,7 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id) >> .init_soc_specific = pwrap_mt2701_init_soc_specific, >> }; >> >> -static struct pmic_wrapper_type pwrap_mt8135 = { >> +static const struct pmic_wrapper_type pwrap_mt8135 = { >> .regs = mt8135_regs, >> .type = PWRAP_MT8135, >> .arb_en_all = 0x1ff, >> @@ -1079,7 +1079,7 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id) >> .init_soc_specific = pwrap_mt8135_init_soc_specific, >> }; >> >> -static struct pmic_wrapper_type pwrap_mt8173 = { >> +static const struct pmic_wrapper_type pwrap_mt8173 = { >> .regs = mt8173_regs, >> .type = PWRAP_MT8173, >> .arb_en_all = 0x3f, >> @@ -1091,7 +1091,7 @@ static irqreturn_t pwrap_interrupt(int irqno, void *dev_id) >> .init_soc_specific = pwrap_mt8173_init_soc_specific, >> }; >> >> -static struct of_device_id of_pwrap_match_tbl[] = { >> +static const struct of_device_id of_pwrap_match_tbl[] = { >> { >> .compatible = "mediatek,mt2701-pwrap", >> .data = &pwrap_mt2701, > > Acked-by: Chen Zhong > Applied to v4.13-next/soc Thanks a lot, Matthias