Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753145AbdHBLlr (ORCPT ); Wed, 2 Aug 2017 07:41:47 -0400 Received: from mail-io0-f179.google.com ([209.85.223.179]:36434 "EHLO mail-io0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752138AbdHBLlq (ORCPT ); Wed, 2 Aug 2017 07:41:46 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170802075126.17637-1-brgl@bgdev.pl> <20170802075126.17637-5-brgl@bgdev.pl> <2153314.vmO4TSUiTO@ws-stein> From: Linus Walleij Date: Wed, 2 Aug 2017 13:41:44 +0200 Message-ID: Subject: Re: [PATCH 4/6] gpio: mxc: use devres for irq generic chip To: Andy Shevchenko Cc: Alexander Stein , Bartosz Golaszewski , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 21 On Wed, Aug 2, 2017 at 10:32 AM, Andy Shevchenko wrote: > On Wed, Aug 2, 2017 at 11:09 AM, Alexander Stein > wrote: >> On Wednesday 02 August 2017 09:51:24, Bartosz Golaszewski wrote: >>> Use resource managed variants of irq_alloc_generic_chip() and >>> irq_setup_generic_chip(). >> >> Is this really useful for drivers which can only be built-in? > > But you still can unbind the driver and its ->remove() will be called > (in case of no remove, devres still on the table), right? Maybe the patches need to be combines with a .suppress_bind_attrs = true in the driver struct? I backed out the patches I applied, I thought the series were older, sorry stressed at work today. Yours, Linus Walleij