Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753174AbdHBLnH (ORCPT ); Wed, 2 Aug 2017 07:43:07 -0400 Received: from atrey.karlin.mff.cuni.cz ([195.113.26.193]:51699 "EHLO atrey.karlin.mff.cuni.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753046AbdHBLnG (ORCPT ); Wed, 2 Aug 2017 07:43:06 -0400 Date: Wed, 2 Aug 2017 13:43:04 +0200 From: Pavel Machek To: Marek Belisko Cc: sre@kernel.org, robh+dt@kernel.org, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, hns@goldelico.com, Marek Belisko Subject: Re: [RFC PATCH 1/5] dt-bindings: power: Add battery types Message-ID: <20170802114304.GB2765@amd> References: <1501620926-22669-1-git-send-email-marek.belisko@open-nandra.com> <1501620926-22669-2-git-send-email-marek.belisko@open-nandra.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="E39vaYmALEf/7YXx" Content-Disposition: inline In-Reply-To: <1501620926-22669-2-git-send-email-marek.belisko@open-nandra.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1694 Lines: 63 --E39vaYmALEf/7YXx Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi! > Signed-off-by: Marek Belisko > --- > include/dt-bindings/power/power.h | 11 +++++++++++ > 1 file changed, 11 insertions(+) > create mode 100644 include/dt-bindings/power/power.h >=20 > diff --git a/include/dt-bindings/power/power.h b/include/dt-bindings/powe= r/power.h > new file mode 100644 > index 0000000..ea36d7f > --- /dev/null > +++ b/include/dt-bindings/power/power.h > @@ -0,0 +1,11 @@ > +#ifndef _DT_BINDINGS_POWER_H > +#define _DT_BINDINGS_POWER_H > + > +#define POWER_SUPPLY_TECHNOLOGY_NiMH 1 > +#define POWER_SUPPLY_TECHNOLOGY_LION 2 > +#define POWER_SUPPLY_TECHNOLOGY_LIPO 3 > +#define POWER_SUPPLY_TECHNOLOGY_LiFe 4 Actually I'd add comments here, such as "/* LiFePO4 */, because otherwise it is a bit ambiguous. > +#define POWER_SUPPLY_TECHNOLOGY_NiCd 5 > +#define POWER_SUPPLY_TECHNOLOGY_LiMn 6 > + > +#endif /* _DT_BINDINGS_POWER_H */ The rest of series is ok, you can add Acked-by: Pavel Machek , but I guess someone would want a little more verbose changelogs. BTW what hardware are you working with? Pavel --=20 (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blo= g.html --E39vaYmALEf/7YXx Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iEYEARECAAYFAlmBusgACgkQMOfwapXb+vLr3QCgrkkhOd8aSFo+4I3+QsBcKwIJ 1a0An1Vh67BNyYLS3k4QCSC8mvrjafoH =jF+n -----END PGP SIGNATURE----- --E39vaYmALEf/7YXx--