Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753217AbdHBLyM (ORCPT ); Wed, 2 Aug 2017 07:54:12 -0400 Received: from mail-qk0-f181.google.com ([209.85.220.181]:34874 "EHLO mail-qk0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753045AbdHBLyK (ORCPT ); Wed, 2 Aug 2017 07:54:10 -0400 MIME-Version: 1.0 X-Originating-IP: [90.63.244.31] In-Reply-To: References: <20170802075126.17637-1-brgl@bgdev.pl> <20170802075126.17637-5-brgl@bgdev.pl> <2153314.vmO4TSUiTO@ws-stein> From: Bartosz Golaszewski Date: Wed, 2 Aug 2017 13:54:09 +0200 Message-ID: Subject: Re: [PATCH 4/6] gpio: mxc: use devres for irq generic chip To: Linus Walleij Cc: Andy Shevchenko , Alexander Stein , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1069 Lines: 28 2017-08-02 13:41 GMT+02:00 Linus Walleij : > On Wed, Aug 2, 2017 at 10:32 AM, Andy Shevchenko > wrote: >> On Wed, Aug 2, 2017 at 11:09 AM, Alexander Stein >> wrote: >>> On Wednesday 02 August 2017 09:51:24, Bartosz Golaszewski wrote: >>>> Use resource managed variants of irq_alloc_generic_chip() and >>>> irq_setup_generic_chip(). >>> >>> Is this really useful for drivers which can only be built-in? >> >> But you still can unbind the driver and its ->remove() will be called >> (in case of no remove, devres still on the table), right? > > Maybe the patches need to be combines with a > .suppress_bind_attrs = true in the driver struct? > > I backed out the patches I applied, I thought the series were older, > sorry stressed at work today. > gpio-sodaville sets .supress_bind_attrs to true. Other built-in drivers need updates for that, but I think this could go in a separate series as using devres doesn't affect the bind/unbind functionality/issue. Thanks, Bartosz