Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753228AbdHBL4g (ORCPT ); Wed, 2 Aug 2017 07:56:36 -0400 Received: from userp1040.oracle.com ([156.151.31.81]:21455 "EHLO userp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753147AbdHBL4e (ORCPT ); Wed, 2 Aug 2017 07:56:34 -0400 Date: Wed, 2 Aug 2017 14:56:22 +0300 From: Dan Carpenter To: Wolf Entwicklungen Cc: Greg Kroah-Hartman , Marcus Wolf , devel@driverdev.osuosl.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: remove some macros, introduce some inline functions Message-ID: <20170802115622.56ayoh6ogrv347d6@mwanda> References: <20170802115330.uvvzqrimbz2ixoyk@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170802115330.uvvzqrimbz2ixoyk@mwanda> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 257 Lines: 10 On Wed, Aug 02, 2017 at 02:53:30PM +0300, Dan Carpenter wrote: > > +{ > > + u8 tempVal; > Btw, just call this "u8 tmp;". The word "temp" is short for temperature and "val" doesn't add any information because it's clearly a value. regards, dan carpenter