Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753308AbdHBMOk (ORCPT ); Wed, 2 Aug 2017 08:14:40 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:23834 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753130AbdHBMOi (ORCPT ); Wed, 2 Aug 2017 08:14:38 -0400 Date: Wed, 2 Aug 2017 15:14:26 +0300 From: Dan Carpenter To: Marcus Wolf Cc: devel@driverdev.osuosl.org, Greg Kroah-Hartman , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] staging: pi433: remove some macros, introduce some inline functions Message-ID: <20170802121426.l3wmnyeeoig3p44u@mwanda> References: <20170802115330.uvvzqrimbz2ixoyk@mwanda> <1105187501.38159.1501675658122@ox.hosteurope.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1105187501.38159.1501675658122@ox.hosteurope.de> User-Agent: NeoMutt/20170113 (1.7.2) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1093 Lines: 29 On Wed, Aug 02, 2017 at 02:07:37PM +0200, Marcus Wolf wrote: > Hi Dan, > > I get your point and I understand, that there need to be rules to > simplify the life for the maintainers... > > But I honestly must confess, that at the moment, I don't have the > time for doing that. I am into two customer projects, that keep me > very busy these weeks. > > The only thing, I can offer, is to remove all the lines, dealing > with the #ifdef DEBUG and leave the rest, as it is and send it again. > Then all other changes are related to the move from macro to inline... > If that helps, please let me know. > > If it needs further fragmentation, it'll take something like half > a day / a day. I most probably can spent that day end of August, > begin of September the earliest. > One trick that might help is you can just use `git citool` and highlight all the rmw() lines, add selected lines to the commit, then commit that as one patch. Repeat for all five patches. The kernel process does kind of have a steep learning with redoing patches... Sorry about that. regards, dan carpenter