Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751754AbdHBMix (ORCPT ); Wed, 2 Aug 2017 08:38:53 -0400 Received: from mail-it0-f66.google.com ([209.85.214.66]:38687 "EHLO mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbdHBMiv (ORCPT ); Wed, 2 Aug 2017 08:38:51 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:5640:0:960b:2678:e223:c1c6] In-Reply-To: <1501631202-11656-1-git-send-email-cakturk@gmail.com> References: <1501631202-11656-1-git-send-email-cakturk@gmail.com> From: Daniel Vetter Date: Wed, 2 Aug 2017 14:38:50 +0200 X-Google-Sender-Auth: HtulDGse1_tdJ1ausFOfSJlgPto Message-ID: Subject: Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference To: Cihangir Akturk , Linux Kernel Mailing List Cc: Greg KH , Hans de Goede , Michael Thayer , devel@driverdev.osuosl.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1318 Lines: 45 On Wed, Aug 2, 2017 at 1:46 AM, Cihangir Akturk wrote: > drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should > not be used by new code. > > This patch fixes the following warning reported by coccinelle: > > drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put > helpers to reference and dereference obj > > Signed-off-by: Cihangir Akturk Care to do this for all the drm drivers, not just the single one in staging? Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches also go to dri-devel? Thanks, Daniel > --- > drivers/staging/vboxvideo/vbox_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/vboxvideo/vbox_main.c b/drivers/staging/vboxvideo/vbox_main.c > index d0c6ec7..1addeac 100644 > --- a/drivers/staging/vboxvideo/vbox_main.c > +++ b/drivers/staging/vboxvideo/vbox_main.c > @@ -525,7 +525,7 @@ vbox_dumb_mmap_offset(struct drm_file *file, > bo = gem_to_vbox_bo(obj); > *offset = vbox_bo_mmap_offset(bo); > > - drm_gem_object_unreference(obj); > + drm_gem_object_put(obj); > ret = 0; > > out_unlock: > -- > 2.7.4 > -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch