Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752893AbdHBORh (ORCPT ); Wed, 2 Aug 2017 10:17:37 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:33080 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752286AbdHBORf (ORCPT ); Wed, 2 Aug 2017 10:17:35 -0400 MIME-Version: 1.0 X-Originating-IP: [2a02:168:5640:0:960b:2678:e223:c1c6] In-Reply-To: <20170802134756.GA796@mbp> References: <1501631202-11656-1-git-send-email-cakturk@gmail.com> <20170802134756.GA796@mbp> From: Daniel Vetter Date: Wed, 2 Aug 2017 16:17:33 +0200 X-Google-Sender-Auth: fbaRWGggSFfefo57Dhn2bPb4f04 Message-ID: Subject: Re: [PATCH] staging: vboxvideo: use drm_gem_object_put instead of drm_gem_object_unreference To: Cihangir Akturk , dri-devel Cc: Linux Kernel Mailing List , Greg KH , Hans de Goede , Michael Thayer , devel@driverdev.osuosl.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1075 Lines: 37 On Wed, Aug 2, 2017 at 3:47 PM, Cihangir Akturk wrote: > On Wed, Aug 02, 2017 at 02:38:50PM +0200, Daniel Vetter wrote: >> On Wed, Aug 2, 2017 at 1:46 AM, Cihangir Akturk wrote: >> > drm_gem_object_unreference is a compatibility alias for drm_gem_object_put so should >> > not be used by new code. >> > >> > This patch fixes the following warning reported by coccinelle: >> > >> > drivers/staging/vboxvideo/vbox_main.c:528:1-27: WARNING: use get/put >> > helpers to reference and dereference obj >> > >> > Signed-off-by: Cihangir Akturk >> >> Care to do this for all the drm drivers, not just the single one in staging? > > Sure, I'll send a v2 shortly as you suggested. Patch per driver would be better I think, there's probably going to be a _lot_ of hits. Thanks, Daniel > > Thanks. > >> >> Hans/Greg: Can we pls fix up MAINTAINERS to make sure vboxdrm patches >> also go to dri-devel? >> >> Thanks, Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch