Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706AbdHBO43 (ORCPT ); Wed, 2 Aug 2017 10:56:29 -0400 Received: from mail-oi0-f66.google.com ([209.85.218.66]:36015 "EHLO mail-oi0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751900AbdHBO40 (ORCPT ); Wed, 2 Aug 2017 10:56:26 -0400 MIME-Version: 1.0 In-Reply-To: <2578d94a-fd1b-9598-251d-59764a870933@baylibre.com> References: <1501679918-20486-1-git-send-email-oleksandrs@mellanox.com> <1501679918-20486-3-git-send-email-oleksandrs@mellanox.com> <2578d94a-fd1b-9598-251d-59764a870933@baylibre.com> From: Arnd Bergmann Date: Wed, 2 Aug 2017 16:56:25 +0200 X-Google-Sender-Auth: geKTYqfnBuJY3Rwcl_MkCXVLbbc Message-ID: Subject: Re: [patch v1 2/2] drivers: jtag: Add Aspeed SoC 24xx and 25xx families JTAG master driver To: Neil Armstrong Cc: Oleksandr Shamray , gregkh , devicetree@vger.kernel.org, =?UTF-8?B?SmnFmcOtIFDDrXJrbw==?= , system-sw-low-level@mellanox.com, OpenBMC Maillist , Linux Kernel Mailing List , mec@shout.net, Jiri Pirko , Joel Stanley , linux-serial@vger.kernel.org, vadimp@maellanox.com, Tobias Klauser , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 768 Lines: 22 On Wed, Aug 2, 2017 at 4:30 PM, Neil Armstrong wrote: > On 08/02/2017 03:18 PM, Oleksandr Shamray wrote: >> Driver adds support of Aspeed 2500/2400 series SOC JTAG master controller. >> +static u32 aspeed_jtag_read(struct aspeed_jtag *aspeed_jtag, u32 reg) >> +{ >> + return readl(aspeed_jtag->reg_base + reg); >> +} >> + >> +static void >> +aspeed_jtag_write(struct aspeed_jtag *aspeed_jtag, u32 val, u32 reg) >> +{ >> + writel(val, aspeed_jtag->reg_base + reg); >> +} > > Maybe readl_relaxed/writel_relaxed would be enough here. I'd prefer keeping the regular accessors here, unless this is shown to be a performance bottleneck, and there is a comment to explain how the relaxed accessors are determined to be safe. Arnd