Subject: Re: [PATCH] dt-bindings: mtd: add new compatible strings for mtk nor
 controller
To: Boris Brezillon <boris.brezillon@free-electrons.com>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        Marek Vasut <marek.vasut@gmail.com>,
        Cyrille Pitchen <cyrille.pitchen@atmel.com>
Cc: Mark Rutland <mark.rutland@arm.com>, devicetree@vger.kernel.org,
        Guochun Mao <guochun.mao@mediatek.com>,
        Richard Weinberger <richard@nod.at>,
        Russell King <linux@armlinux.org.uk>, linux-kernel@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>, linux-mtd@lists.infradead.org,
        linux-mediatek@lists.infradead.org,
        David Woodhouse <dwmw2@infradead.org>,
        linux-arm-kernel@lists.infradead.org
References: <1500948617-19627-1-git-send-email-guochun.mao@mediatek.com>
 <1500948617-19627-2-git-send-email-guochun.mao@mediatek.com>
 <03016ea3-51ad-0b2d-e824-0a20913bd7c1@gmail.com>
 <20170802103637.16cd6548@bbrezillon>
From: Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>
Message-ID: <535cc2d5-7bc9-2cb7-42cf-9d7058e64226@wedev4u.fr>
Date: Wed, 2 Aug 2017 17:31:01 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170802103637.16cd6548@bbrezillon>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1831
Lines: 57

Hi Guochun,

Le 02/08/2017 à 10:36, Boris Brezillon a écrit :
> Hi Matthias,
> 
> On Tue, 1 Aug 2017 14:33:22 +0200
> Matthias Brugger <matthias.bgg@gmail.com> wrote:
> 
>> On 07/25/2017 04:10 AM, Guochun Mao wrote:
>>> Add "mediatek,mt2712-nor" and "mediatek,mt7622-nor"
>>> for nor flash node's compatible strings.
>>>
>>> Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
>>> Signed-off-by: Guochun Mao <guochun.mao@mediatek.com>
>>> ---
>>>   .../devicetree/bindings/mtd/mtk-quadspi.txt        |    2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> index 5ded66a..9845ff4 100644
>>> --- a/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> +++ b/Documentation/devicetree/bindings/mtd/mtk-quadspi.txt
>>> @@ -3,6 +3,8 @@
>>>   Required properties:
>>>   - compatible: 	  The possible values are:
>>>   		  "mediatek,mt2701-nor"
>>> +		  "mediatek,mt2712-nor"
>>> +		  "mediatek,mt7622-nor"
>>>   		  "mediatek,mt7623-nor"
>>>   		  "mediatek,mt8173-nor"
>>>   		  For mt8173, compatible should be "mediatek,mt8173-nor".
>>>

There should be another patch to update the mtk_nor_of_ids[] array in
the mtk-quadspi.c driver, shouldn't it?

Currently, I only see the "mediatek,mt8173-nor" compatible string at the
driver side. The driver and its documentation should be aligned and both
patches should be applied at the same time.

Best regards,

Cyrille

>>
>> Boris, will you take this through your tree, or do you prefer that I take it?
> 
> I'm not the spi-nor maintainer, you should ask Cyrille or Marek.
> 
> Regards,
> 
> Boris
> 
> ______________________________________________________
> Linux MTD discussion mailing list
> http://lists.infradead.org/mailman/listinfo/linux-mtd/
>