Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752173AbdHBQi1 convert rfc822-to-8bit (ORCPT ); Wed, 2 Aug 2017 12:38:27 -0400 Received: from lhrrgout.huawei.com ([194.213.3.17]:32548 "EHLO lhrrgout.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751974AbdHBQi0 (ORCPT ); Wed, 2 Aug 2017 12:38:26 -0400 From: Salil Mehta To: Florian Fainelli , "davem@davemloft.net" CC: "Zhuangyuzeng (Yisen)" , huangdaode , "lipeng (Y)" , "mehta.salil.lnk@gmail.com" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-rdma@vger.kernel.org" , Linuxarm Subject: RE: [PATCH V4 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC Thread-Topic: [PATCH V4 net-next 1/8] net: hns3: Add support of HNS3 Ethernet Driver for hip08 SoC Thread-Index: AQHTAzd3nWaDWWDuhk+aGcL90Tc4+qJhiR6AgAZ1bACACVU9IA== Date: Wed, 2 Aug 2017 16:38:12 +0000 Message-ID: References: <20170722220942.78852-1-salil.mehta@huawei.com> <20170722220942.78852-2-salil.mehta@huawei.com> <79a3a952-acae-2a51-0d49-46acaf92cf3b@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.203.181.161] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020206.5981FFFF.016A,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=169.254.1.170, so=2013-06-18 04:22:30, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 1caf94e17dd4be25aef4c69278eb1e14 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2474 Lines: 73 Hi Florian, > -----Original Message----- > From: Salil Mehta > Sent: Thursday, July 27, 2017 9:45 PM > To: 'Florian Fainelli'; davem@davemloft.net > Cc: Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm > Subject: RE: [PATCH V4 net-next 1/8] net: hns3: Add support of HNS3 > Ethernet Driver for hip08 SoC > > Hi Florian, > > > -----Original Message----- > > From: Florian Fainelli [mailto:f.fainelli@gmail.com] > > Sent: Sunday, July 23, 2017 6:24 PM > > To: Salil Mehta; davem@davemloft.net > > Cc: Zhuangyuzeng (Yisen); huangdaode; lipeng (Y); > > mehta.salil.lnk@gmail.com; netdev@vger.kernel.org; linux- > > kernel@vger.kernel.org; linux-rdma@vger.kernel.org; Linuxarm > > Subject: Re: [PATCH V4 net-next 1/8] net: hns3: Add support of HNS3 > > Ethernet Driver for hip08 SoC > > > > > > > > On 07/22/2017 03:09 PM, Salil Mehta wrote: > > > This patch adds the support of Hisilicon Network Subsystem 3 > > > Ethernet driver to hip08 family of SoCs. > > > > > > This driver includes basic Rx/Tx functionality. It also includes > > > the client registration code with the HNAE3(Hisilicon Network > > > Acceleration Engine 3) framework. > > > > > > This work provides the initial support to the hip08 SoC and > > > would incrementally add features or enhancements. > > > > > > Signed-off-by: Daode Huang > > > Signed-off-by: lipeng > > > Signed-off-by: Salil Mehta > > > Signed-off-by: Yisen Zhuang [...] > > > > > > + hns3_nic_reclaim_one_desc(ring, &bytes, &pkts); > > > + /* Issue prefetch for next Tx descriptor */ > > > + prefetch(&ring->desc_cb[ring->next_to_clean]); > > > + budget--; > > > + } > > > + > > > + ring->tqp_vector->tx_group.total_bytes += bytes; > > > + ring->tqp_vector->tx_group.total_packets += pkts; > > > + > > > + dev_queue = netdev_get_tx_queue(netdev, ring->tqp->tqp_index); > > > + netdev_tx_completed_queue(dev_queue, pkts, bytes); > > > > Where is flow control happening? Should not you wake the transmit > queue > > if you had to stop it somehow? > Forgive me, I could not get this part. Flow control of what? As discussed with you earlier, I have fixed the queue wakeup part in Patch V6. Please have a look at it. Thanks! Best regards Salil > > > > > > I kind of stopped reviewing here. > > -- > > Florian