Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753139AbdHBRTM (ORCPT ); Wed, 2 Aug 2017 13:19:12 -0400 Received: from mga01.intel.com ([192.55.52.88]:33923 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752740AbdHBRTK (ORCPT ); Wed, 2 Aug 2017 13:19:10 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.41,312,1498546800"; d="scan'208";a="118780697" Message-ID: <1501694063.29303.361.camel@linux.intel.com> Subject: Re: [PATCH 0/2] serial: 8250: add support for MediaTek BTIF controller From: Andy Shevchenko To: sean.wang@mediatek.com, robh+dt@kernel.org, gregkh@linuxfoundation.org, jslaby@suse.com, jan.kiszka@siemens.com, heikki.krogerus@linux.intel.com, hpeter@gmail.com, vigneshr@ti.com, matthias.bgg@gmail.com Cc: devicetree@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-serial@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Date: Wed, 02 Aug 2017 20:14:23 +0300 In-Reply-To: References: Organization: Intel Finland Oy Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.22.6-1 Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1593 Lines: 44 On Thu, 2017-08-03 at 01:05 +0800, sean.wang@mediatek.com wrote: > From: Sean Wang > > This patchset introduces the support for MediaTek BTIF controller. > > MediaTek BTIF controller is the serial interface similar to UART but > it > works only as the digital device which is mainly used to communicate > with > the connectivity module also called CONNSYS inside the SoC which could > be > mostly found on those MediaTek SoCs with Bluetooth feature. > > And the controller is made as being compatible with the 8250 register > layout so it tends to be integrated with existing 8250 core driver and > have no requirement for the modem configuration additionally such as > the > baud rate calculation and assignment. Why it requires a separate driver? 8250_of is for DT enabled drivers. > > Sean Wang (2): >   dt-bindings: serial: Add MediaTek BTIF controller bindings >   tty: serial: 8250: Add MediaTek BTIF controller on MT7622 and MT7623 >     SoC > >  .../devicetree/bindings/serial/mtk-btif.txt        |  26 +++ >  drivers/tty/serial/8250/8250_btif.c                | 224 > +++++++++++++++++++++ >  drivers/tty/serial/8250/Kconfig                    |   9 + >  drivers/tty/serial/8250/Makefile                   |   1 + >  4 files changed, 260 insertions(+) >  create mode 100644 Documentation/devicetree/bindings/serial/mtk- > btif.txt >  create mode 100644 drivers/tty/serial/8250/8250_btif.c > -- Andy Shevchenko Intel Finland Oy