Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752019AbdHBXsF (ORCPT ); Wed, 2 Aug 2017 19:48:05 -0400 Received: from mail.kernel.org ([198.145.29.99]:51144 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751927AbdHBXsE (ORCPT ); Wed, 2 Aug 2017 19:48:04 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 1D18D22BEA Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=rostedt@goodmis.org Date: Wed, 2 Aug 2017 19:48:01 -0400 From: Steven Rostedt To: Federico Vaga Cc: LKML Subject: Re: [PATCH V3 1/2] trace-cmd record: use direname instead of custom code Message-ID: <20170802194801.2ad46a59@gandalf.local.home> In-Reply-To: <20170802221558.9684-1-federico.vaga@vaga.pv.it> References: <20170802221558.9684-1-federico.vaga@vaga.pv.it> X-Mailer: Claws Mail 3.14.0 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 653 Lines: 18 On Thu, 3 Aug 2017 00:15:57 +0200 Federico Vaga wrote: > Prefer well known functions like `dirname(3)` instead of custom > implementation for the same functionality > > Signed-off-by: Federico Vaga Thanks. I'll be traveling for a bit and wont get to these before I leave. Just a note. When sending patches, can you add to the subject, something like I just did "trace-cmd record:" to let those know that this is a trace-cmd patch (especially when sent to LKML). It also makes it easier for me when I look for trace-cmd patches, as I will filter on "trace-cmd" in the subject. Thanks, -- Steve