Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751870AbdHCAwc (ORCPT ); Wed, 2 Aug 2017 20:52:32 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:38206 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751174AbdHCAwa (ORCPT ); Wed, 2 Aug 2017 20:52:30 -0400 Date: Wed, 2 Aug 2017 17:52:22 -0700 From: Darren Hart To: Shuah Khan Cc: shuah@kernel.org, tglx@linutronix.de, mingo@redhat.com, peterz@infradead.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH] selftests: futex: fix run_tests target Message-ID: <20170803005222.GC27974@fury> References: <20170802223142.20282-1-shuahkh@osg.samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170802223142.20282-1-shuahkh@osg.samsung.com> User-Agent: Mutt/1.8.0 (2017-02-23) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1433 Lines: 43 On Wed, Aug 02, 2017 at 04:31:42PM -0600, Shuah Khan wrote: > make -C tools/testing/selftests/futex/ run_tests doesn't run the tests. > Running run_tests target only when $(OUTPUT) is the $(PWD) is incorrect. > When $(OUTPUT) is empty, run_tests will not run. Fix it. > > Fixes: a8ba798bc8ec ("selftests: enable O and KBUILD_OUTPUT") > Signed-off-by: Shuah Khan So this indeed addresses the problem you reported. I'm curious about why this was changed like it was. I presume to avoid some issues with relative paths, like the ./run.sh and the "cd functional" within run.sh.... but I haven't been able to trigger that. When you say $(OUTPUT) is empty - when does that occur? Because if it was in fact "" then the change below would attempt to execute /run.sh ... which is surely not what we want. > --- > tools/testing/selftests/futex/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/futex/Makefile b/tools/testing/selftests/futex/Makefile > index e2fbb890aef9..7c647f619d63 100644 > --- a/tools/testing/selftests/futex/Makefile > +++ b/tools/testing/selftests/futex/Makefile > @@ -14,7 +14,7 @@ all: > done > > override define RUN_TESTS > - @if [ `dirname $(OUTPUT)` = $(PWD) ]; then ./run.sh; fi > + $(OUTPUT)/run.sh > endef > > override define INSTALL_RULE > -- > 2.11.0 > > -- Darren Hart VMware Open Source Technology Center