Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751140AbdHCFPY (ORCPT ); Thu, 3 Aug 2017 01:15:24 -0400 Received: from bh-25.webhostbox.net ([208.91.199.152]:49655 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750850AbdHCFPW (ORCPT ); Thu, 3 Aug 2017 01:15:22 -0400 Subject: Re: [PATCH] watchdog: moxart_wdt: Replace decimal permissions with 4 digit octal To: SZ Lin , wim@iguana.be Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org References: <20170729091543.11777-1-sz.lin@moxa.com> From: Guenter Roeck Message-ID: <9775443d-5b4e-4022-51a4-af678489d1a2@roeck-us.net> Date: Wed, 2 Aug 2017 22:15:19 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170729091543.11777-1-sz.lin@moxa.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: authenticated_id: linux@roeck-us.net X-Authenticated-Sender: bh-25.webhostbox.net: linux@roeck-us.net X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 959 Lines: 30 On 07/29/2017 02:15 AM, SZ Lin wrote: > ERROR: Use 4 digit octal (0777) not decimal permissions > > This error was detected by checkpatch.pl > > Signed-off-by: SZ Lin I think checkpatch is overdoing it a bit here. There are more than 2,000 of those. Plus, I really don't see the value in this change. Guenter > --- > drivers/watchdog/moxart_wdt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/watchdog/moxart_wdt.c b/drivers/watchdog/moxart_wdt.c > index 2c4a73d1e214..05684aa89b88 100644 > --- a/drivers/watchdog/moxart_wdt.c > +++ b/drivers/watchdog/moxart_wdt.c > @@ -170,7 +170,7 @@ static struct platform_driver moxart_wdt_driver = { > }; > module_platform_driver(moxart_wdt_driver); > > -module_param(heartbeat, int, 0); > +module_param(heartbeat, int, 0000); > MODULE_PARM_DESC(heartbeat, "Watchdog heartbeat in seconds"); > > MODULE_DESCRIPTION("MOXART watchdog driver"); >