Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752049AbdHCG1R (ORCPT ); Thu, 3 Aug 2017 02:27:17 -0400 Received: from mx2.suse.de ([195.135.220.15]:48664 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751220AbdHCG1P (ORCPT ); Thu, 3 Aug 2017 02:27:15 -0400 Subject: Re: [PATCH v2 02/13] mpt3sas: Add nvme device support in slave alloc, target alloc and probe To: Suganath Prabu S , jejb@kernel.org, hch@infradead.org Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org, Sathya.Prakash@broadcom.com, kashyap.desai@broadcom.com, linux-kernel@vger.kernel.org, chaitra.basappa@broadcom.com, sreekanth.reddy@broadcom.com, linux-nvme@lists.infradead.org References: <1500038560-11231-1-git-send-email-suganath-prabu.subramani@broadcom.com> <1500038560-11231-3-git-send-email-suganath-prabu.subramani@broadcom.com> From: Hannes Reinecke Message-ID: <5fb13656-0f40-fdc4-8612-ec1bf04cf696@suse.de> Date: Thu, 3 Aug 2017 08:27:13 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 MIME-Version: 1.0 In-Reply-To: <1500038560-11231-3-git-send-email-suganath-prabu.subramani@broadcom.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1570 Lines: 40 On 07/14/2017 03:22 PM, Suganath Prabu S wrote: > 1) Added support for probing pcie device and adding NVMe drives to > SML and driver's internal list pcie_device_list. > > 2) Added support for determing NVMe as boot device. > > 3) Added nvme device support for call back functions scan_finished > target_alloc,slave_alloc,target destroy and slave destroy. > > a) During scan, pcie devices are probed and added to SML to drivers > internal list. > > b) target_alloc & slave alloc API's allocates resources for > (MPT3SAS_TARGET & MPT3SAS_DEVICE) private datas and holds > information like handle, target_id etc. > > c) slave_destroy & target_destroy are called when driver unregisters > or removes device. Also frees allocated resources and info. > > Signed-off-by: Chaitra P B > Signed-off-by: Suganath Prabu S > --- > drivers/scsi/mpt3sas/mpt3sas_base.h | 110 ++++++++- > drivers/scsi/mpt3sas/mpt3sas_scsih.c | 431 +++++++++++++++++++++++++++++++--- > 2 files changed, 507 insertions(+), 34 deletions(-) > Have you considered using 'scan_start()/scan_finished()' SCSI midlayer callbacks here? Seeing that you are enumerating the devices internally already that should give you better control about the scanning process. Cheers, Hannes -- Dr. Hannes Reinecke Teamlead Storage & Networking hare@suse.de +49 911 74053 688 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: F. Imendörffer, J. Smithard, J. Guild, D. Upmanyu, G. Norton HRB 21284 (AG Nürnberg)