Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752091AbdHCHtB (ORCPT ); Thu, 3 Aug 2017 03:49:01 -0400 Received: from mail-ve1eur01on0085.outbound.protection.outlook.com ([104.47.1.85]:19040 "EHLO EUR01-VE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751840AbdHCHs4 (ORCPT ); Thu, 3 Aug 2017 03:48:56 -0400 From: =?iso-8859-2?Q?Horia_Geant=E3?= To: Herbert Xu CC: Harald Freudenberger , Oleksij Rempel , "linux-kernel@vger.kernel.org" , Oleksij Rempel , "Dan Douglass" , "linux-crypto@vger.kernel.org" , "kernel@pengutronix.de" , Martin Schwidefsky , "David S. Miller" Subject: Re: [PATCH v1] crypto: caam - set hwrng quality level Thread-Topic: [PATCH v1] crypto: caam - set hwrng quality level Thread-Index: AQHTAGL5pmG33iaaT0uDieR7tYnZTg== Date: Thu, 3 Aug 2017 07:48:51 +0000 Message-ID: References: <20170719074458.9247-1-o.rempel@pengutronix.de> <20170719163248.sn7mvnq2s3fm2hvh@pengutronix.de> <20170719181303.rj4fyjj7qplatrzk@pengutronix.de> <4e42d639-9f83-dcbb-9a2a-91686656c7dd@linux.vnet.ibm.com> <20170803031652.GA10515@gondor.apana.org.au> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=horia.geanta@nxp.com; x-originating-ip: [192.88.146.1] x-ms-publictraffictype: Email x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2622;6:3eoibR98RWyU9kggebhAQnWpUercDHkA0acWlYjGqkUOH2llR8vI6nZoNTCU0LNhRk7a5DT4SFYT97lEhLBUX/tm9NHV8B2wpX3IAC0BRzjaCT0U/0H+TwXt0C105wXdybeaJOygOhFAZ/Zl8tOblzvuJSao062NzDBLjlLhhlxofKeXea2Ea5bz78ovUmNRi3QqtkjM9WaIWfk0M2PEfYg0FpGZG36fmmStSSig5SB3InHQsjJOMDiVge8K+Lgea+PKTbp4/84gczK5zmJPvK5XM9FjbOp7HoEzDeaQjpmgu/k+ElSTeELoP7VW40aEBNe7cfKrM6yWwPDtdAabMw==;5:ls7XzpP5wyi6Srkv1yzmIqPL5frjBNQrxD7XgXZO3XSlhczyoj6CaKig7nMXZpyV+7TSabqX5k8hEFTnLClaRJRXG461ZFwoyw8zKeZsr/397D5XA8ZhsF3TfwFNPawwJ0ZtbNK7A3OTyq7pMDv8eQ==;24:rSPKOWOyJ4YaFIWiCr+ivQ3Dlrn87Rg7Df3CyD3TMqNrYOvMskCMSpUOELa3ClyWTKZWzClLFYJfdj3hUGvwRWC2Y7XY49mf5FbYBz/8CKc=;7:Q2oG8/3MXVynBe4CB/lzPrcUlm2o26YBTJubESZI2CIxudGdtV7bzAzXlWpeFo09Q4M7GXhg5sPSngmF+EPO7GeUYEfhCvCaTQqFSqwDncsPt0gxMDv0r5MUV+uJ1Efec0PZ5Of5/gqBtTeyhdRbNadSR61ePmI59dHT7hzLGN2UPzNBjwdY5myhmxZeu6NYkkuZYedSx4H46OQx2AEYt00cNT+b5Ytqvm4jeYePdQI= x-forefront-antispam-report: SFV:SKI;SCL:-1;SFV:NSPM;SFS:(10009020)(6009001)(39840400002)(39400400002)(39850400002)(39410400002)(39860400002)(39450400003)(24454002)(199003)(189002)(377454003)(5250100002)(101416001)(7736002)(54356999)(8676002)(97736004)(81156014)(50986999)(305945005)(81166006)(68736007)(2900100001)(105586002)(106356001)(66066001)(8936002)(53546010)(86362001)(74316002)(14454004)(33656002)(25786009)(3660700001)(93886004)(110136004)(6116002)(38730400002)(3846002)(102836003)(5660300001)(9686003)(6246003)(53936002)(99286003)(478600001)(7696004)(2906002)(189998001)(55016002)(229853002)(6916009)(4326008)(76176999)(3280700002)(6506006)(54906002)(6436002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2622;H:VI1PR0401MB2591.eurprd04.prod.outlook.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; x-ms-office365-filtering-correlation-id: a96496d5-9bee-4d13-5cfa-08d4da44157a x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(48565401081)(2017052603031)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:VI1PR0401MB2622; x-ms-traffictypediagnostic: VI1PR0401MB2622: x-exchange-antispam-report-test: UriScan:; x-microsoft-antispam-prvs: x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(100000703101)(100105400095)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123558100)(20161123555025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:VI1PR0401MB2622;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:VI1PR0401MB2622; x-forefront-prvs: 03883BD916 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Aug 2017 07:48:51.7335 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2622 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v737nBQm027502 Content-Length: 729 Lines: 19 On 8/3/2017 6:17 AM, Herbert Xu wrote: > On Wed, Aug 02, 2017 at 02:03:14PM +0000, Horia Geant? wrote: >> >> Take CAAM's engine HWRNG: it can work both as a TRNG and as a >> TRNG-seeded DRBG (that's how it's currently configured). >> IIUC, both setups are fit as source for the entropy pool. > > So which is it? If it's a DRBG then it should not be exposed through > the hwrng interface. Only TRNG should go through hwrng. DRBGs > can use the crypto rng API. Right now it's configured as a DRBG. If I read correctly, it doesn't matter it's using the internal TRNG for (automated) seeding, it still shouldn't use hwrng. This means it's broken since the very beginning: e24f7c9e87d4 crypto: caam - hwrng support Thanks, Horia