Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751913AbdHCJS6 (ORCPT <rfc822;w@1wt.eu>);
        Thu, 3 Aug 2017 05:18:58 -0400
Received: from mail-lf0-f41.google.com ([209.85.215.41]:36336 "EHLO
        mail-lf0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751211AbdHCJSz (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 3 Aug 2017 05:18:55 -0400
Subject: Re: [PATCH v3 2/4] dt-bindings: can: fixed-transceiver: Add new CAN
 fixed transceiver bindings
To: Franklin S Cooper Jr <fcooper@ti.com>, linux-kernel@vger.kernel.org,
        devicetree@vger.kernel.org, netdev@vger.kernel.org,
        linux-can@vger.kernel.org, wg@grandegger.com, mkl@pengutronix.de,
        robh+dt@kernel.org, quentin.schulz@free-electrons.com,
        dev.kurt@vandijck-laurijssen.be, andrew@lunn.ch,
        socketcan@hartkopp.net
References: <20170803005150.9286-1-fcooper@ti.com>
 <20170803005150.9286-3-fcooper@ti.com>
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Message-ID: <f92513b6-6b2b-e08d-72e2-dedd7e0190f4@cogentembedded.com>
Date: Thu, 3 Aug 2017 12:18:52 +0300
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170803005150.9286-3-fcooper@ti.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1698
Lines: 48

Hello!

On 8/3/2017 3:51 AM, Franklin S Cooper Jr wrote:

> Add documentation to describe usage of the new fixed transceiver binding.
> This new binding is applicable for any CAN device therefore it exists as
> its own document.
> 
> Signed-off-by: Franklin S Cooper Jr <fcooper@ti.com>
> ---
>   .../bindings/net/can/fixed-transceiver.txt         | 24 ++++++++++++++++++++++
>   1 file changed, 24 insertions(+)
>   create mode 100644 Documentation/devicetree/bindings/net/can/fixed-transceiver.txt
> 
> diff --git a/Documentation/devicetree/bindings/net/can/fixed-transceiver.txt b/Documentation/devicetree/bindings/net/can/fixed-transceiver.txt
> new file mode 100644
> index 0000000..2f58838b
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/net/can/fixed-transceiver.txt
> @@ -0,0 +1,24 @@
> +Fixed transceiver Device Tree binding
> +------------------------------
> +
> +CAN transceiver typically limits the max speed in standard CAN and CAN FD
> +modes. Typically these limitations are static and the transceivers themselves
> +provide no way to detect this limitation at runtime. For this situation,
> +the "fixed-transceiver" node can be used.
> +
> +Required Properties:
> + max-bitrate:	a positive non 0 value that determines the max
> +		speed that CAN/CAN-FD can run. Any other value
> +		will be ignored.
> +
> +Examples:
> +
> +Based on Texas Instrument's TCAN1042HGV CAN Transceiver
> +
> +m_can0 {
> +	....
> +	fixed-transceiver@0 {

    The <unit-address> (after @) must only be specified if there's "reg" prop 
in the device node. Also, please name the node "can-transceiver@" to be more 
in line with the DT spec. which requires generic node names.

[...]

MBR, Sergei