Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752181AbdHCJ5j (ORCPT ); Thu, 3 Aug 2017 05:57:39 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:48808 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930AbdHCJ5e (ORCPT ); Thu, 3 Aug 2017 05:57:34 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 92B72607A3 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=kvalo@codeaurora.org Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: qtfnmac: Tidy up DMA mask setting From: Kalle Valo In-Reply-To: <2c3f47792b2e38d5584d641d98e82f8318fefc72.1500917445.git.robin.murphy@arm.com> References: <2c3f47792b2e38d5584d641d98e82f8318fefc72.1500917445.git.robin.murphy@arm.com> To: Robin Murphy Cc: imitsyanko@quantenna.com, avinashp@quantenna.com, smatyukevich@quantenna.com, linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org User-Agent: pwcli/0.0.0-git (https://github.com/kvalo/pwcli/) Python/2.7.12 Message-Id: <20170803095733.B5D09607A3@smtp.codeaurora.org> Date: Thu, 3 Aug 2017 09:57:33 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 833 Lines: 19 Robin Murphy wrote: > As the only caller of dma_supported() outside of DMA API internals, the > qtfnmac driver stands out and invites scrutiny. Thankfully, it's not > being used for evil, but it is entirely redundant, since it open-codes a > check that the DMA mask setting functions are going to perform anyway. > In fact, the whole qtnf_pcie_init_dma_mask() function is nothing more > than a rather long-winded implementation of dma_set_mask_and_coherent(), > so let's just use that directly. > > Signed-off-by: Robin Murphy > Acked-by: Sergey Matyukevich There's a typo in title prefix, I'll fix it to "qtnfmac:". -- https://patchwork.kernel.org/patch/9859961/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches