Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752074AbdHCKkY (ORCPT ); Thu, 3 Aug 2017 06:40:24 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39078 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751820AbdHCKkW (ORCPT ); Thu, 3 Aug 2017 06:40:22 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A6692C0587CB Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=hdegoede@redhat.com Subject: Re: [PATCH] staging: vboxvideo: select DRM_TTM To: Cihangir Akturk , gregkh@linuxfoundation.org Cc: michael.thayer@oracle.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org References: <1501610741-10018-1-git-send-email-cakturk@gmail.com> From: Hans de Goede Message-ID: Date: Thu, 3 Aug 2017 12:40:20 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <1501610741-10018-1-git-send-email-cakturk@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Thu, 03 Aug 2017 10:40:22 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1006 Lines: 38 Hi, On 01-08-17 20:05, Cihangir Akturk wrote: > vboxvideo code uses various ttm_* functions, so it needs > "drivers/gpu/drm/ttm/*" to be built. In order to build these objects > select DRM_TTM. > > This commit fixes "ttm_*" undefined build errors. > > Signed-off-by: Cihangir Akturk Thank you for doing this, I had this on my todo list but I was travelling: Acked-by: Hans de Goede Regards, Hans > --- > drivers/staging/vboxvideo/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/staging/vboxvideo/Kconfig b/drivers/staging/vboxvideo/Kconfig > index f89f931..1f4182e 100644 > --- a/drivers/staging/vboxvideo/Kconfig > +++ b/drivers/staging/vboxvideo/Kconfig > @@ -2,6 +2,7 @@ config DRM_VBOXVIDEO > tristate "Virtual Box Graphics Card" > depends on DRM && X86 && PCI > select DRM_KMS_HELPER > + select DRM_TTM > select GENERIC_ALLOCATOR > help > This is a KMS driver for the virtual Graphics Card used in >