DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 630F2C04B317
Subject: Re: [PATCH RFC 0/2] KVM: x86: generalize guest cpuid helpers
To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= <rkrcmar@redhat.com>,
        linux-kernel@vger.kernel.org, kvm@vger.kernel.org
Cc: Paolo Bonzini <pbonzini@redhat.com>
References: <20170802204147.3586-1-rkrcmar@redhat.com>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <2bc44983-64ef-38ff-2a29-fa6c61247ccc@redhat.com>
Date: Thu, 3 Aug 2017 13:53:06 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <20170802204147.3586-1-rkrcmar@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 789
Lines: 29

On 02.08.2017 22:41, Radim Krčmář wrote:
> This series does the generalization that we've spoken about recently
> Might be a good time to change the function names as well.
> 
> 
> Radim Krčmář (2):
>   KVM: x86: generalize guest_cpuid_has_ helpers
>   KVM: x86: use general helpers for some cpuid manipulation
> 
>  arch/x86/kvm/cpuid.h | 205 ++++++++++++++++++---------------------------------
>  arch/x86/kvm/mmu.c   |   7 +-
>  arch/x86/kvm/mtrr.c  |   2 +-
>  arch/x86/kvm/svm.c   |   7 +-
>  arch/x86/kvm/vmx.c   |  33 ++++-----
>  arch/x86/kvm/x86.c   |  52 ++++++-------
>  6 files changed, 116 insertions(+), 190 deletions(-)
> 

These numbers speak for themselves.

I really like this cleanup!

Had a quick look over the patches, nothing jumped at me.

-- 

Thanks,

David