Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752137AbdHCL4n (ORCPT ); Thu, 3 Aug 2017 07:56:43 -0400 Received: from fllnx209.ext.ti.com ([198.47.19.16]:16365 "EHLO fllnx209.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751140AbdHCL4l (ORCPT ); Thu, 3 Aug 2017 07:56:41 -0400 Subject: Re: [PATCH v3 3/4] dt-bindings: can: m_can: Include reference to new fixed transceiver binding To: Sergei Shtylyov , , , , , , , , , , , References: <20170803005150.9286-1-fcooper@ti.com> <20170803005150.9286-4-fcooper@ti.com> <53a5346e-9c04-738e-432c-16cdcc4c6e60@cogentembedded.com> From: Franklin S Cooper Jr Message-ID: <83c7dc26-a046-bfc1-79fc-6ac6a1e1e205@ti.com> Date: Thu, 3 Aug 2017 04:54:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <53a5346e-9c04-738e-432c-16cdcc4c6e60@cogentembedded.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [172.22.130.217] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1782 Lines: 54 On 08/03/2017 04:20 AM, Sergei Shtylyov wrote: > On 8/3/2017 3:51 AM, Franklin S Cooper Jr wrote: > >> Add information regarding fixed transceiver binding. This is especially >> important for MCAN since the IP allows CAN FD mode to run significantly >> faster than what most transceivers are capable of. >> >> Signed-off-by: Franklin S Cooper Jr >> --- >> Documentation/devicetree/bindings/net/can/m_can.txt | 9 +++++++++ >> 1 file changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/net/can/m_can.txt >> b/Documentation/devicetree/bindings/net/can/m_can.txt >> index 9e33177..0b62f47 100644 >> --- a/Documentation/devicetree/bindings/net/can/m_can.txt >> +++ b/Documentation/devicetree/bindings/net/can/m_can.txt >> @@ -43,6 +43,11 @@ Required properties: >> Please refer to 2.4.1 Message RAM Configuration in >> Bosch M_CAN user manual for details. >> +Optional properties: >> +- fixed-transceiver : Fixed-transceiver subnode describing maximum >> speed > > Subnode is not a property. Ok makes sense. Several bindings refer to fixed-link as an optional property. I thought there was some kind of weird reasoning to do so which I decided to follow. I'll update it to say "Optional subnode". > >> + that can be used for CAN/CAN-FD modes. See >> + >> Documentation/devicetree/bindings/net/can/fixed-transceiver.txt >> + for details. >> Example: >> SoC dtsi: >> m_can1: can@020e8000 { >> @@ -64,4 +69,8 @@ Board dts: >> pinctrl-names = "default"; >> pinctrl-0 = <&pinctrl_m_can1>; >> status = "enabled"; >> + >> + fixed-transceiver@0 { > > Same comments here as in previous patch. Will fix. > > [...] > > MBR, Sergei