Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752108AbdHCMXU convert rfc822-to-8bit (ORCPT ); Thu, 3 Aug 2017 08:23:20 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:53080 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751685AbdHCMXS (ORCPT ); Thu, 3 Aug 2017 08:23:18 -0400 From: Gregory CLEMENT To: Marcin Wojtas Cc: Miquel RAYNAL , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, thomas.petazzoni@free-electrons.com, andrew@lunn.ch, marc.zyngier@arm.com, jaz@semihalf.com, hannah@marvell.com, nadavh@marvell.com, neta@marvell.com, mark.rutland@arm.com, zbodek@gmail.com Subject: Re: [PATCH] ARM64: dts: marvell: armada-37xx: Enable uSD on ESPRESSObin References: <1500594636-19911-1-git-send-email-mw@semihalf.com> <20170802191608.58aa312e@xps13> Date: Thu, 03 Aug 2017 14:23:07 +0200 In-Reply-To: <20170802191608.58aa312e@xps13> (Miquel RAYNAL's message of "Wed, 2 Aug 2017 19:16:08 +0200") Message-ID: <873798alhw.fsf@free-electrons.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2314 Lines: 93 Hi Marcin, On mer., août 02 2017, Miquel RAYNAL wrote: > Hi, > > On Fri, 21 Jul 2017 01:50:36 +0200 > Marcin Wojtas wrote: > >> The ESPRESSObin board exposes one of the SDHCI interfaces >> via J1 uSD slot. This patch enables it. >> >> Signed-off-by: Marcin Wojtas >> Signed-off-by: Zbigniew Bodek > > Tested-by: Miquel Raynal Applied on mvebu/dt64 (I also removed the "no-1-8-v" property while applying it becauseit was obviously wrong) Thanks, Gregory > >> --- >> .../boot/dts/marvell/armada-3720-espressobin.dts | 26 >> ++++++++++++++++++++++ 1 file changed, 26 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts >> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts index >> b1af3f98..6d0caf1 100644 --- >> a/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts +++ >> b/arch/arm64/boot/dts/marvell/armada-3720-espressobin.dts @@ -45,6 >> +45,7 @@ >> /dts-v1/; >> >> +#include >> #include "armada-372x.dtsi" >> >> / { >> @@ -59,6 +60,20 @@ >> device_type = "memory"; >> reg = <0x00000000 0x00000000 0x00000000 0x20000000>; >> }; >> + >> + vcc_sd_reg1: regulator { >> + compatible = "regulator-gpio"; >> + regulator-name = "vcc_sd1"; >> + regulator-min-microvolt = <1800000>; >> + regulator-max-microvolt = <3300000>; >> + regulator-boot-on; >> + >> + gpios = <&gpionb 4 GPIO_ACTIVE_HIGH>; >> + gpios-states = <0>; >> + states = <1800000 0x1 >> + 3300000 0x0>; >> + enable-active-high; >> + }; >> }; >> >> /* J9 */ >> @@ -71,6 +86,17 @@ >> status = "okay"; >> }; >> >> +/* J1 */ >> +&sdhci1 { >> + wp-inverted; >> + bus-width = <4>; >> + cd-gpios = <&gpionb 3 GPIO_ACTIVE_LOW>; >> + no-1-8-v; >> + marvell,pad-type = "sd"; >> + vqmmc-supply = <&vcc_sd_reg1>; >> + status = "okay"; >> +}; >> + >> /* Exported on the micro USB connector J5 through an FTDI */ >> &uart0 { >> status = "okay"; > > > > -- > Miquel Raynal, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com