Subject: Re: [PATCH 28/29] drm/vmwgfx: switch to drm_*{get,put} helpers
To: Cihangir Akturk <cakturk@gmail.com>
Cc: VMware Graphics <linux-graphics-maintainer@vmware.com>,
        Sinclair Yeh <syeh@vmware.com>, David Airlie <airlied@linux.ie>,
        dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <1501761585-11757-1-git-send-email-cakturk@gmail.com>
 <1501761585-11757-29-git-send-email-cakturk@gmail.com>
From: Thomas Hellstrom <thellstrom@vmware.com>
Message-ID: <82c874fa-9cf9-d3a3-6424-fc6e9745c4c9@vmware.com>
Date: Thu, 3 Aug 2017 14:40:43 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <1501761585-11757-29-git-send-email-cakturk@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
SpamDiagnosticOutput: 1:99
SpamDiagnosticMetadata: NSPM
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Aug 2017 12:40:57.0567 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR05MB755
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1916
Lines: 60

On 08/03/2017 01:58 PM, Cihangir Akturk wrote:
> drm_*_reference() and drm_*_unreference() functions are just
> compatibility alias for drm_*_get() and drm_*_put() adn should not be

s/adn/and/
> used by new code. So convert all users of compatibility functions to use
> the new APIs.
>
> Signed-off-by: Cihangir Akturk <cakturk@gmail.com>
> ---
>   drivers/gpu/drm/vmwgfx/vmwgfx_fb.c    | 2 +-
>   drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 4 ++--
>   2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> index 6f4cb46..d43dce9 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fb.c
> @@ -500,7 +500,7 @@ static int vmw_fb_kms_detach(struct vmw_fb_par *par,
>   	}
>   
>   	if (cur_fb) {
> -		drm_framebuffer_unreference(cur_fb);
> +		drm_framebuffer_put(cur_fb);
>   		par->set_fb = NULL;
>   	}
>   
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> index 5ec24fd..fd4a988 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c
> @@ -316,7 +316,7 @@ int vmw_present_ioctl(struct drm_device *dev, void *data,
>   out_no_surface:
>   	ttm_read_unlock(&dev_priv->reservation_sem);
>   out_no_ttm_lock:
> -	drm_framebuffer_unreference(fb);
> +	drm_framebuffer_put(fb);
>   out_no_fb:
>   	drm_modeset_unlock_all(dev);
>   out_no_copy:
> @@ -393,7 +393,7 @@ int vmw_present_readback_ioctl(struct drm_device *dev, void *data,
>   
>   	ttm_read_unlock(&dev_priv->reservation_sem);
>   out_no_ttm_lock:
> -	drm_framebuffer_unreference(fb);
> +	drm_framebuffer_put(fb);
>   out_no_fb:
>   	drm_modeset_unlock_all(dev);
>   out_no_copy:

Apart from the above,

Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>

(Assuming this gets pulled together with the whole series, not vmwgfx-next)

Thanks,

Thomas