DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 54E425FB26
Subject: Re: [PATCH 3/3] KVM: nVMX: Emulate EPTP switching for the L1
 hypervisor
To: David Hildenbrand <david@redhat.com>, Bandan Das <bsd@redhat.com>,
        kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, jmattson@google.com, linux-kernel@vger.kernel.org
References: <20170801232433.31749-1-bsd@redhat.com>
 <20170801232433.31749-4-bsd@redhat.com>
 <56d21524-1a08-8281-fb01-950fb7c10b2f@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <179e5832-0dca-0b5f-b303-d5de18353f5e@redhat.com>
Date: Thu, 3 Aug 2017 14:41:04 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <56d21524-1a08-8281-fb01-950fb7c10b2f@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 857
Lines: 32

On 03/08/2017 13:39, David Hildenbrand wrote:
>> +	/* AD, if set, should be supported */
>> +	if ((address & VMX_EPT_AD_ENABLE_BIT)) {
>> +		if (!enable_ept_ad_bits)
>> +			return false;
> In theory (I guess) we would have to check here if
> (vmx->nested.nested_vmx_ept_caps & VMX_EPT_AD_BIT)

Yes, that's a more correct check than enable_ept_ad_bits.

>>
>> +	page = nested_get_page(vcpu, vmcs12->eptp_list_address);
>> +	if (!page)
>> +		return 1;
>> +
>> +	l1_eptp_list = kmap(page);
>> +	address = l1_eptp_list[index];
>> +	accessed_dirty = !!(address & VMX_EPT_AD_ENABLE_BIT);
> 
> Minor nit: Can't you directly do
> 
> kunmap(page);
> nested_release_page_clean(page);
> 
> at this point?
> 
> We can fix this up later.

You actually can do simply kvm_vcpu_read_guest_page(vcpu,
vmcs12->eptp_list_address >> PAGE_SHIFT, &address, index * 8, 8).

Paolo