DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 24DB861472
Subject: Re: [PATCH 3/3] KVM: nVMX: Emulate EPTP switching for the L1
 hypervisor
To: Paolo Bonzini <pbonzini@redhat.com>, Bandan Das <bsd@redhat.com>,
        kvm@vger.kernel.org
Cc: rkrcmar@redhat.com, jmattson@google.com, linux-kernel@vger.kernel.org
References: <20170801232433.31749-1-bsd@redhat.com>
 <20170801232433.31749-4-bsd@redhat.com>
 <56d21524-1a08-8281-fb01-950fb7c10b2f@redhat.com>
 <179e5832-0dca-0b5f-b303-d5de18353f5e@redhat.com>
From: David Hildenbrand <david@redhat.com>
Organization: Red Hat GmbH
Message-ID: <c1e59f97-9a31-6213-035b-e723ba26ca78@redhat.com>
Date: Thu, 3 Aug 2017 14:47:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <179e5832-0dca-0b5f-b303-d5de18353f5e@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 494
Lines: 28


>> Minor nit: Can't you directly do
>>
>> kunmap(page);
>> nested_release_page_clean(page);
>>
>> at this point?
>>
>> We can fix this up later.
> 
> You actually can do simply kvm_vcpu_read_guest_page(vcpu,
> vmcs12->eptp_list_address >> PAGE_SHIFT, &address, index * 8, 8).
> 

Fascinating how nested is able to confuse me every time :) . Sure, this
is just a G1 address, not a G2 address ... (maybe we should rename
nested_get_page to guest_get_page ...)

> Paolo
> 


-- 

Thanks,

David