Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751791AbdHCNJe (ORCPT ); Thu, 3 Aug 2017 09:09:34 -0400 Received: from mx2.suse.de ([195.135.220.15]:32784 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751144AbdHCNJd (ORCPT ); Thu, 3 Aug 2017 09:09:33 -0400 Date: Thu, 3 Aug 2017 15:09:29 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: "Coelho, Luciano" cc: "linux-kernel@vger.kernel.org" , linuxwifi , "Zhang, Rui" , "edubezval@gmail.com" , "linux-pm@vger.kernel.org" , "Weinehall, David" , "Berg, Johannes" , "kvalo@codeaurora.org" , "Sharon, Sara" , "linux-wireless@vger.kernel.org" , "Grumbach, Emmanuel" Subject: Re: [linuxwifi] x86/thermal: AB-BA dependency between mvm->mutex and tz->lock In-Reply-To: Message-ID: References: <1501753405.15969.43.camel@intel.com> <87vam5nf4w.fsf@kamboji.qca.qualcomm.com> <1501759724.15969.49.camel@intel.com> User-Agent: Alpine 2.20 (LSU 67 2015-01-07) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 20 On Thu, 3 Aug 2017, Jiri Kosina wrote: > > I see the workqueue allocation you mentioned. I'll try to move this > > allocation out of the mutex and see how it goes. > > I have been briefly looking into this as well -- it'll basically have to > be moved out of the trans_pcie->mutex context, but > > (a) I'm not sure whether that's actually safe > (b) iwl_pcie_rx_reuse_rbd() (which is where corresponding work is being > queued) is not a proper context either (it's atomic context) Actually moving it out of trans_pcie->mutex is likely not to be enough, the dependency would still be there, just the graph will have one vertex less, with the dependency going directly from mvm mutex to cpu_hotplug_lock. -- Jiri Kosina SUSE Labs