Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751963AbdHCNa4 (ORCPT ); Thu, 3 Aug 2017 09:30:56 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:50672 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751162AbdHCNaz (ORCPT ); Thu, 3 Aug 2017 09:30:55 -0400 Date: Thu, 3 Aug 2017 15:30:53 +0200 From: Andrew Lunn To: Egil Hjelmeland Cc: vivien.didelot@savoirfairelinux.com, f.fainelli@gmail.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v3 net-next 5/5] net: dsa: lan9303: refactor lan9303_get_ethtool_stats Message-ID: <20170803133053.GE15018@lunn.ch> References: <20170803094507.3439-1-privat@egil-hjelmeland.no> <20170803094507.3439-6-privat@egil-hjelmeland.no> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170803094507.3439-6-privat@egil-hjelmeland.no> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 336 Lines: 10 On Thu, Aug 03, 2017 at 11:45:07AM +0200, Egil Hjelmeland wrote: > In lan9303_get_ethtool_stats: Get rid of 0x400 constant magic > by using new lan9303_read_switch_reg() inside loop. > Reduced scope of two variables. > > Signed-off-by: Egil Hjelmeland Reviewed-by: Andrew Lunn Andrew