Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752048AbdHCNh4 (ORCPT ); Thu, 3 Aug 2017 09:37:56 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:50756 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751953AbdHCNhx (ORCPT ); Thu, 3 Aug 2017 09:37:53 -0400 Subject: Re: [PATCH 2/3] drm/vc4: Don't disable DSI clocks on component unload. To: Eric Anholt , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org References: <20170802203242.12815-1-eric@anholt.net> <20170802203242.12815-2-eric@anholt.net> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: Date: Thu, 3 Aug 2017 15:37:33 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170802203242.12815-2-eric@anholt.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 912 Lines: 28 Den 02.08.2017 22.32, skrev Eric Anholt: > The clocks are enabled/disabled at encoder enable/disable time, not at > component load. Fixes a WARN_ON at boot if V3D fails to probe. > > Fixes: 4078f5757144 ("drm/vc4: Add DSI driver") > Signed-off-by: Eric Anholt > --- Acked-by: Noralf Trønnes > drivers/gpu/drm/vc4/vc4_dsi.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c > index 629d372633e6..13481bb6322f 100644 > --- a/drivers/gpu/drm/vc4/vc4_dsi.c > +++ b/drivers/gpu/drm/vc4/vc4_dsi.c > @@ -1641,9 +1641,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master, > > mipi_dsi_host_unregister(&dsi->dsi_host); > > - clk_disable_unprepare(dsi->pll_phy_clock); > - clk_disable_unprepare(dsi->escape_clock); > - > if (dsi->port == 1) > vc4->dsi1 = NULL; > }