Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752059AbdHCNiJ (ORCPT ); Thu, 3 Aug 2017 09:38:09 -0400 Received: from smtp.domeneshop.no ([194.63.252.55]:50582 "EHLO smtp.domeneshop.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751154AbdHCNiI (ORCPT ); Thu, 3 Aug 2017 09:38:08 -0400 Subject: Re: [PATCH 3/3] drm/vc4: Fix errant drm_bridge_remove() in DSI. To: Eric Anholt , dri-devel@lists.freedesktop.org Cc: linux-kernel@vger.kernel.org References: <20170802203242.12815-1-eric@anholt.net> <20170802203242.12815-3-eric@anholt.net> From: =?UTF-8?Q?Noralf_Tr=c3=b8nnes?= Message-ID: <1c0c49d0-63f4-28d8-7088-2b21ba4d8a3e@tronnes.org> Date: Thu, 3 Aug 2017 15:37:49 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 MIME-Version: 1.0 In-Reply-To: <20170802203242.12815-3-eric@anholt.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 26 Den 02.08.2017 22.32, skrev Eric Anholt: > drm_bridge_remove() is for unregistering a bridge driver, not for > detaching a bridge from its consumer. > > Fixes: 656fa22f9cea ("drm/vc4: Switch DSI to the panel-bridge layer, and support bridges.") > Signed-off-by: Eric Anholt > --- Acked-by: Noralf Trønnes > drivers/gpu/drm/vc4/vc4_dsi.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/gpu/drm/vc4/vc4_dsi.c b/drivers/gpu/drm/vc4/vc4_dsi.c > index 13481bb6322f..d1e0dc908048 100644 > --- a/drivers/gpu/drm/vc4/vc4_dsi.c > +++ b/drivers/gpu/drm/vc4/vc4_dsi.c > @@ -1636,7 +1636,6 @@ static void vc4_dsi_unbind(struct device *dev, struct device *master, > > pm_runtime_disable(dev); > > - drm_bridge_remove(dsi->bridge); > vc4_dsi_encoder_destroy(dsi->encoder); > > mipi_dsi_host_unregister(&dsi->dsi_host);