Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751352AbdHCNku (ORCPT ); Thu, 3 Aug 2017 09:40:50 -0400 Received: from szxga01-in.huawei.com ([45.249.212.187]:10761 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751010AbdHCNks (ORCPT ); Thu, 3 Aug 2017 09:40:48 -0400 Subject: Re: [PATCH v4] acpi/iort: numa: Add numa node mapping for smmuv3 devices To: Lorenzo Pieralisi , Robert Richter References: <20170725050237.11033-1-ganapatrao.kulkarni@cavium.com> <20170725151305.GU17961@rric.localdomain> <20170802162119.GA3984@red-moon> <598326B1.7040508@huawei.com> CC: Ganapatrao Kulkarni , , , , , , , , , , , , , , From: Hanjun Guo Message-ID: <598327B6.8030201@huawei.com> Date: Thu, 3 Aug 2017 21:40:06 +0800 User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <598326B1.7040508@huawei.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.17.188] X-CFilter-Loop: Reflected X-Mirapoint-Virus-RAPID-Raw: score=unknown(0), refid=str=0001.0A020203.598327C3.0089,ss=1,re=0.000,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0, ip=0.0.0.0, so=2014-11-16 11:51:01, dmn=2013-03-21 17:37:32 X-Mirapoint-Loop-Id: 3d2a58b5575537f373ccbe057c25c5bb Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2485 Lines: 59 On 2017/8/3 21:35, Hanjun Guo wrote: > On 2017/8/3 0:21, Lorenzo Pieralisi wrote: >> > Patch that I will send upstream below, please check, thanks. >> > >> > -- >8 -- >> > Subject: [PATCH] ACPI/IORT: numa: Add numa node mapping for smmuv3 devices >> > >> > ARM IORT specification(rev. C) has added provision to define proximity >> > domain in SMMUv3 IORT table. Adding required code to parse Proximity >> > domain and set numa_node of smmv3 platform devices. >> > >> > Add code to parse proximity domain in SMMUv3 IORT table to >> > set numa node mapping for smmuv3 devices. >> > >> > Link: http://lkml.kernel.org/r/20170706112017.GA16981@rric.localdomain >> > Signed-off-by: Ganapatrao Kulkarni >> > [lorenzo.pieralisi@arm.com: updated review comments] >> > Signed-off-by: Lorenzo Pieralisi >> > --- >> > drivers/acpi/arm64/iort.c | 29 ++++++++++++++++++++++++++++- >> > 1 file changed, 28 insertions(+), 1 deletion(-) >> > >> > diff --git a/drivers/acpi/arm64/iort.c b/drivers/acpi/arm64/iort.c >> > index a3215ee..35dd803 100644 >> > --- a/drivers/acpi/arm64/iort.c >> > +++ b/drivers/acpi/arm64/iort.c >> > @@ -908,6 +908,27 @@ static bool __init arm_smmu_v3_is_coherent(struct acpi_iort_node *node) >> > return smmu->flags & ACPI_IORT_SMMU_V3_COHACC_OVERRIDE; >> > } >> > >> > +#if defined(CONFIG_ACPI_NUMA) && defined(ACPI_IORT_SMMU_v3_PXM_VALID) > Typo here, s/v3/V3, wit this typo, smmu proximity callback will be set to NULL. > >> > +/* >> > + * set numa proximity domain for smmuv3 device >> > + */ >> > +static void __init arm_smmu_v3_set_proximity(struct device *dev, >> > + struct acpi_iort_node *node) >> > +{ >> > + struct acpi_iort_smmu_v3 *smmu; >> > + >> > + smmu = (struct acpi_iort_smmu_v3 *)node->node_data; >> > + if (smmu->flags & ACPI_IORT_SMMU_V3_PXM_VALID) { >> > + set_dev_node(dev, acpi_map_pxm_to_node(smmu->pxm)); >> > + dev_info(dev, "SMMUV3[%llx] Mapped to Proximity domain %d\n", >> > + smmu->base_address, >> > + smmu->pxm); > Here I got: > > [ 5.074246] (null): SMMUV3[a0040000] Mapped to Proximity domain 0 > [ 5.074296] (null): SMMUV3[700a0040000] Mapped to Proximity domain 2 > [ 5.074319] (null): SMMUV3[c0040000] Mapped to Proximity domain 0 > [ 5.074344] (null): SMMUV3[8a0040000] Mapped to Proximity domain 1 > [ 5.074368] (null): SMMUV3[600a0040000] Mapped to Proximity domain 2 And SMMU-v3 or SMMUv3 is better I think. Thanks Hanjun