Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751911AbdHCN4K (ORCPT ); Thu, 3 Aug 2017 09:56:10 -0400 Received: from lelnx193.ext.ti.com ([198.47.27.77]:15822 "EHLO lelnx193.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751775AbdHCN4J (ORCPT ); Thu, 3 Aug 2017 09:56:09 -0400 Subject: Re: [PATCH 23/29] drm/tilcdc: switch to drm_*{get,put} helpers To: Cihangir Akturk CC: Tomi Valkeinen , David Airlie , , References: <1501761585-11757-1-git-send-email-cakturk@gmail.com> <1501761585-11757-24-git-send-email-cakturk@gmail.com> From: Jyri Sarha Message-ID: <3ed06ee9-6c17-2cb3-f1c4-72901ef7dc17@ti.com> Date: Thu, 3 Aug 2017 16:56:04 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1501761585-11757-24-git-send-email-cakturk@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-GB X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id v73DuFQL018509 Content-Length: 1781 Lines: 58  Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki. Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki On 08/03/17 14:58, Cihangir Akturk wrote: > drm_*_reference() and drm_*_unreference() functions are just > compatibility alias for drm_*_get() and drm_*_put() adn should not be > used by new code. So convert all users of compatibility functions to use > the new APIs. > > Signed-off-by: Cihangir Akturk Acked-by: Jyri Sarha This appears to be a part of a larger series. So I guess it will go in via drm-misc. But if this is not the case just let me know and I'll add this to my next pull request. Best Regards, Jyri > --- > drivers/gpu/drm/tilcdc/tilcdc_crtc.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > index d524ed0..6e936dd 100644 > --- a/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > +++ b/drivers/gpu/drm/tilcdc/tilcdc_crtc.c > @@ -75,7 +75,7 @@ static void unref_worker(struct drm_flip_work *work, void *val) > struct drm_device *dev = tilcdc_crtc->base.dev; > > mutex_lock(&dev->mode_config.mutex); > - drm_framebuffer_unreference(val); > + drm_framebuffer_put(val); > mutex_unlock(&dev->mode_config.mutex); > } > > @@ -456,7 +456,7 @@ static void tilcdc_crtc_set_mode(struct drm_crtc *crtc) > > set_scanout(crtc, fb); > > - drm_framebuffer_reference(fb); > + drm_framebuffer_get(fb); > > crtc->hwmode = crtc->state->adjusted_mode; > } > @@ -621,7 +621,7 @@ int tilcdc_crtc_update_fb(struct drm_crtc *crtc, > return -EBUSY; > } > > - drm_framebuffer_reference(fb); > + drm_framebuffer_get(fb); > > crtc->primary->fb = fb; > tilcdc_crtc->event = event; >