Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751900AbdHCO4K (ORCPT ); Thu, 3 Aug 2017 10:56:10 -0400 Received: from mail.free-electrons.com ([62.4.15.54]:57042 "EHLO mail.free-electrons.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751206AbdHCO4I (ORCPT ); Thu, 3 Aug 2017 10:56:08 -0400 Date: Thu, 3 Aug 2017 16:56:06 +0200 From: Boris Brezillon To: Arvind Yadav Cc: airlied@linux.ie, daniel.vetter@ffwll.ch, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] drm/atmel-hlcdc : constify drm_plane_helper_funcs and drm_plane_funcs. Message-ID: <20170803165606.69e5e34e@bbrezillon> In-Reply-To: <646415a3b2e62182f85254115e8491e5caf4b2c7.1499098826.git.arvind.yadav.cs@gmail.com> References: <646415a3b2e62182f85254115e8491e5caf4b2c7.1499098826.git.arvind.yadav.cs@gmail.com> X-Mailer: Claws Mail 3.13.2 (GTK+ 2.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1909 Lines: 49 On Mon, 3 Jul 2017 21:53:54 +0530 Arvind Yadav wrote: > drm_plane_helper_funcs and drm_plane_funcsare not supposed to change > at runtime. All functions working with drm_plane_helper_funcs and > drm_plane_funcs work with const. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 6072 596 0 6668 1a0c atmel_hlcdc_plane.o > > File size After adding 'const': > text data bss dec hex filename > 6218 436 0 6654 19fe atmel_hlcdc_plane.o > > Signed-off-by: Arvind Yadav Applied to drm-misc-next. Thanks, Boris > --- > drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > index 29cc10d..ea72e1f 100644 > --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_plane.c > @@ -911,7 +911,7 @@ void atmel_hlcdc_plane_irq(struct atmel_hlcdc_plane *plane) > desc->name); > } > > -static struct drm_plane_helper_funcs atmel_hlcdc_layer_plane_helper_funcs = { > +static const struct drm_plane_helper_funcs atmel_hlcdc_layer_plane_helper_funcs = { > .atomic_check = atmel_hlcdc_plane_atomic_check, > .atomic_update = atmel_hlcdc_plane_atomic_update, > .atomic_disable = atmel_hlcdc_plane_atomic_disable, > @@ -1020,7 +1020,7 @@ static void atmel_hlcdc_plane_atomic_destroy_state(struct drm_plane *p, > kfree(state); > } > > -static struct drm_plane_funcs layer_plane_funcs = { > +static const struct drm_plane_funcs layer_plane_funcs = { > .update_plane = drm_atomic_helper_update_plane, > .disable_plane = drm_atomic_helper_disable_plane, > .set_property = drm_atomic_helper_plane_set_property,